armaVargas• 120
@ArmaVargas
Submitted
Mohit kulkarni
@burningbeattle
All comments
- Mohit kulkarni• 40
@burningbeattle
Posted
image height and width can be improve the size restoration of it as per design try to tweak and can achive the same can give the perfect result
0 - Ugiomoh Daniel• 200
@dannyswagg
Submitted
Mohit kulkarni• 40@burningbeattle
Posted
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…
Your <ul> <li> text should be wrapped with a <a> so it is accessible with a keyboard using the tab key,
<ul> <li>GitHub</li> <li>Frontend Mentor</li> <li>LinkedIn</li> <li>Twitter</li> <li>Instagram</li> </ul> This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation), <meta> description tag missing that helps search engine determine what the page is about, Something like this <meta name="description" content="" />Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.
Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning .
Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained .- Another great resource for px to rem converter .
Using font-display: swap in your @font-face rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear.
Having a clear and descriptive alt text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines use alt text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images ,
Using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM ,
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
0 - Khalid Mir• 160
@khalidmir2674
Submitted
What are you most proud of, and what would you do differently next time?
My development speed is increasing with every challenge.
What challenges did you encounter, and how did you overcome them?
I have not encountered any challenges.
What specific areas of your project would you like help with?
Any feedback is highly appreciated
Mohit kulkarni• 40@burningbeattle
Posted
There are a few adjustments that can be made to improve the code's structure, design, and accessibility. Here’s a breakdown of the changes:
- HTML Code Adjustments Semantic Structure: The structure is already mostly semantic, but we can improve it slightly by wrapping the h2, paragraph text, and metadata (like the date) in meaningful semantic elements like article, section, etc.
Alt Text for Images: The alt text for the avatar image is empty. This should describe the image for accessibility purposes.
CSS Code Improvements Box Shadow: The current shadow looks too sharp. Soften the shadow to improve the card’s visual appeal.
Responsive Design Tweaks: Some additional responsive adjustments could be made, especially with the padding and font sizes on smaller screens.
Flexbox Adjustments: Centering the entire body with flexbox works, but to prevent any accidental overflow, it's best to explicitly set margins and widths.
Key Improvement Box-Shadow Soften: The shadow is now less harsh, which gives the card a more modern feel. Hover Effect: Added a subtle hover effect that moves the card up slightly when hovered, making the UI feel more interactive. Responsive Design: Improved the padding and font size for smaller screens to ensure readability and layout don’t break. Improved Avatar Styling: Ensured the avatar is circular and always aligned correctly.
General Suggestions: Accessibility: Consider adding aria-labels to key elements (like the image and buttons), so that screen readers can properly describe them. Lazy Loading: Implement lazy loading on the images (loading="lazy") to improve performance on slower networks
0 - Ugiomoh Daniel• 200
@dannyswagg
Submitted
Mohit kulkarni• 40@burningbeattle
Posted
Your HTML and CSS code for the QR code component looks solid, but there are a few suggestions for improvement:
HTML Suggestions: Semantic HTML:
Consider using semantic HTML elements where possible. For instance, you could use <section> instead of <div class="card-head"> and <div class="card-body"> for better clarity and accessibility. Image alt Text:
Make the alt text of the image more descriptive. Instead of "qr-code", you might use something like "QR code for Frontend Mentor website" to give users with screen readers more context. Accessibility:
Add lang="en" to the <html> tag if it's not already present in your setup for better accessibility.
CSS Suggestions: Consistency:
The padding and margin values might be improved for consistency. For example, the padding on .card and p might be standardized. Unit Consistency:
Consider using rem or em units consistently for font sizes and spacing to maintain scalability and accessibility. Class Naming:
Make sure class names are descriptive and avoid using generic names like .image. You might use .card-image for clarity. Box Shadow:
Adding a subtle box-shadow to the .card might help it stand out more against the background.
These suggestions aim to enhance the readability, accessibility, and visual appeal of your component. Adjustments are meant to be helpful and can be tailored to fit your specific design and functionality needs.
0
