@SunilBaghel002Submitted about 1 month ago
Mohit kulkarni
@burningbeattleAll comments
- @burningbeattlePosted 30 days ago
The code is well-structured and functional, with a clean HTML layout, responsive CSS, and effective JavaScript validation. Here are the key points of feedback:
HTML: Well-organized and semantic, but consider wrapping the input and button in a <form> tag for better accessibility and functionality (e.g., enabling the "Enter" key for submission).
CSS: The design is responsive and flexbox is used effectively. However, consider refining breakpoints for better responsiveness and improving validation feedback by using CSS pseudo-classes like :invalid.
JavaScript: The validation logic works, but adding real-time feedback as users type and using the form's submit event (instead of button click) would enhance the user experience. Additionally, reset the form state when dismissing the success message.
Overall, a few tweaks to accessibility, validation, and form behavior will improve the project. Great job!
Marked as helpful0 - @i-prkrSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I am glad that I was able to making the interaction more enjoyable with CSS transitions, and also that I am beginning to understand accessibility better and how to make solutions more accessible. Next time I need to make sure that I consider the build out for both size designs before structuring the HTML, I had to make some large changes part way through to make the layout change correctly.
What challenges did you encounter, and how did you overcome them?I had some challenges with the layout of the footer between the open and closed sharebar, wanting to make sure the share bar position did not move to make it appear cleaner. I had to play around with the HTML structure and padding on different elements until the content was aligned on the card footer and the share bar.
What specific areas of your project would you like help with?I would greatly appreciate some help with two things:
-
The CSS transition is not working correctly on the live site, but it works fine in the dev environment with parcel and I don't know why. On the live site, the position of the share bar before being opened is defaulting to the wrong location, so the transition is starting from the wrong place. In the large layout, it should start just below where it appears, but instead is starting from the middle of the card. In the small layout, it should scale up from the share button location. I don't know why it only works in local, I have tried using both the scss and css file for the parcel dev environment and both work fine, until it is deployed.
-
When I use a screen reader it won't read out anything more than the level on heading of 'article preview component', and I'm not sure why as I think I have my HTML structured correctly. Any suggestions to improve accessibility would be great too.
Any help would be greatly appreciated thank you for looking at my solution!
@burningbeattlePosted about 2 months agoYour HTML code is well-structured and incorporates good practices for accessibility and responsiveness. By addressing the minor issues and implementing the suggested improvements, you can enhance the user experience, accessibility, and performance of your component. Always remember to test your changes across different browsers and devices to ensure consistency and functionality.
0 -
- @ownedbyanonymousSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that l could use the grid layout to create a responsive layout and that l am finally getting the hang of media-queries.
What challenges did you encounter, and how did you overcome them?I had challenges with the positioning of the quotation mark image in the first grid item/ testimonial. I still have knowledge gaps in the use of the absolute and relative values when dealing with the position property. Your feedback will greatly be appreciated!
What specific areas of your project would you like help with?- Use of absolute and relative values of the position property. (What was the best way to position the quotation mark image in the first testimonial)
- Are there areas l could refactor to avoid the use of media-queries. Your feedback will greatly be appreciated!
@burningbeattlePosted about 2 months agoya this one is better than mine nyc work mate i struggled a lot doing this look like color schemes are not same as given in style guide . like gray box with gray text is not matching and is not good in design perspective .
0 - @SunilBaghel002Submitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
Next time, i would made more understandable website with better design
What challenges did you encounter, and how did you overcome them?I encounter challenges while making website responsive and overcome using flexbox and grid in css.
What specific areas of your project would you like help with?I like fully responsiveness in this website
@burningbeattlePosted about 2 months agoSemantic HTML:
Use <article> or <figure> for each card to enhance semantics. Provide descriptive alt text for images. Accessibility:
Ensure color contrasts meet WCAG standards. Make sure all interactive elements (if any) are keyboard navigable. Use ARIA roles only when necessary. Responsive Layout:
Adopt a mobile-first approach using min-width media queries. Test across various devices and screen sizes. Ensure consistent spacing and sizing across breakpoints. Code Structure:
Implement BEM naming conventions for better scalability. Consolidate repetitive CSS rules. Organize CSS for readability, possibly using preprocessors. Adherence to Design:
Ensure pixel-perfect accuracy in font sizes, spacing, and element dimensions. Implement design-specific interactivity like hover effects. Correct file path typos (assets instead of assests). Optimize font loading by using <link> instead of @import. Use relative units (rem, em) for better scalability. Add transitions and hover effects to improve user experience. By addressing these areas, your project will not only be more robust and maintainable but also provide a better user experience across different devices and for all users, including those relying on assistive technologies.
0 - @WhitezerDSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
This project was the most accurated and attention to the details as much as i could.
What challenges did you encounter, and how did you overcome them?-It's how to position elements when use media queries.
-How to use width on main object properly
-How to set proper line-height for bigger font size
What specific areas of your project would you like help with?From the challenges so here were the problems
- I have a problem to figure out how to make equal width of the two sections equal. -I have tried to use flex-grow for each one and set flex-basis to 0 but it doesn't work. -The solution i've use, i don't think it's the best approach. -What's the best way to adjust width on the element according to my project. and should use rem or em. because no matter what it was inherit from their parent (in this case was html) -I saw the proper line-height settings here : https://www.joshwcomeau.com/css/custom-css-reset/ and i use this for my css rules
- { line-height: calc(1em + 0.5rem); }
But the line height of my h1 was overlap. so i adjust it manually after CSS reset. So i still don't clear how to use this rule properly.
@burningbeattlePosted about 2 months agojust a review done by chatgpt hence i am also nub in this hence reviewing code is more difficult than writing and understanding : ). all points are given by AI hence thanks for achieving the solution just similar to given
-
Removed unnecessary backslashes in @font-face declarations and recommended renaming font files to eliminate commas.
-
Ensured that class names in HTML and CSS match, especially after simplifying class names in the revised HTML.
-
Removed the invalid content: url() from .img-title and relied on the HTML <picture> element for responsive images.
-
Added word-wrap: break-word; and hyphens: auto; to .p__content to handle long words and improve text flow.
-
Changed the centering method from absolute positioning to Flexbox on the main container for better responsiveness and maintainability.
-
Added focus styles to the .btn--add-cart button and ensured semantic HTML by using a <button> element instead of an <a> tag.
-
Applied consistent BEM naming conventions across classes to enhance readability and maintainability.
-
Adjusted media queries to ensure elements scale appropriately on larger screens without relying on fixed widths.
-
Added box shadows, improved line heights, and added transition effects to enhance the visual appeal and user experience.
-
Added cursor: pointer; to buttons to indicate interactivity
By implementing these changes, your Product Preview Card Component will be more robust, accessible, and maintainable. Additionally, adhering to best practices in CSS will ensure that your component remains scalable and performs well across different devices and browsers.
Marked as helpful0 - @ArmaVargasSubmitted 2 months ago@burningbeattlePosted 2 months ago
image height and width can be improve the size restoration of it as per design try to tweak and can achive the same can give the perfect result
0 - @dannyswaggSubmitted 4 months ago@burningbeattlePosted 2 months ago
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…
Your <ul> <li> text should be wrapped with a <a> so it is accessible with a keyboard using the tab key,
<ul> <li>GitHub</li> <li>Frontend Mentor</li> <li>LinkedIn</li> <li>Twitter</li> <li>Instagram</li> </ul> This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation), <meta> description tag missing that helps search engine determine what the page is about, Something like this <meta name="description" content="" />Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.
Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning .
Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained .- Another great resource for px to rem converter .
Using font-display: swap in your @font-face rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear.
Having a clear and descriptive alt text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines use alt text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images ,
Using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM ,
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
0 - @khalidmir2674Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
My development speed is increasing with every challenge.
What challenges did you encounter, and how did you overcome them?I have not encountered any challenges.
What specific areas of your project would you like help with?Any feedback is highly appreciated
@burningbeattlePosted 2 months agoThere are a few adjustments that can be made to improve the code's structure, design, and accessibility. Here’s a breakdown of the changes:
- HTML Code Adjustments Semantic Structure: The structure is already mostly semantic, but we can improve it slightly by wrapping the h2, paragraph text, and metadata (like the date) in meaningful semantic elements like article, section, etc.
Alt Text for Images: The alt text for the avatar image is empty. This should describe the image for accessibility purposes.
CSS Code Improvements Box Shadow: The current shadow looks too sharp. Soften the shadow to improve the card’s visual appeal.
Responsive Design Tweaks: Some additional responsive adjustments could be made, especially with the padding and font sizes on smaller screens.
Flexbox Adjustments: Centering the entire body with flexbox works, but to prevent any accidental overflow, it's best to explicitly set margins and widths.
Key Improvement Box-Shadow Soften: The shadow is now less harsh, which gives the card a more modern feel. Hover Effect: Added a subtle hover effect that moves the card up slightly when hovered, making the UI feel more interactive. Responsive Design: Improved the padding and font size for smaller screens to ensure readability and layout don’t break. Improved Avatar Styling: Ensured the avatar is circular and always aligned correctly.
General Suggestions: Accessibility: Consider adding aria-labels to key elements (like the image and buttons), so that screen readers can properly describe them. Lazy Loading: Implement lazy loading on the images (loading="lazy") to improve performance on slower networks
Marked as helpful0 - @dannyswaggSubmitted 2 months ago@burningbeattlePosted 2 months ago
Your HTML and CSS code for the QR code component looks solid, but there are a few suggestions for improvement:
HTML Suggestions: Semantic HTML:
Consider using semantic HTML elements where possible. For instance, you could use <section> instead of <div class="card-head"> and <div class="card-body"> for better clarity and accessibility. Image alt Text:
Make the alt text of the image more descriptive. Instead of "qr-code", you might use something like "QR code for Frontend Mentor website" to give users with screen readers more context. Accessibility:
Add lang="en" to the <html> tag if it's not already present in your setup for better accessibility.
CSS Suggestions: Consistency:
The padding and margin values might be improved for consistency. For example, the padding on .card and p might be standardized. Unit Consistency:
Consider using rem or em units consistently for font sizes and spacing to maintain scalability and accessibility. Class Naming:
Make sure class names are descriptive and avoid using generic names like .image. You might use .card-image for clarity. Box Shadow:
Adding a subtle box-shadow to the .card might help it stand out more against the background.
These suggestions aim to enhance the readability, accessibility, and visual appeal of your component. Adjustments are meant to be helpful and can be tailored to fit your specific design and functionality needs.
0
