Frontend Mentor | Bernard Addy-Sackey's profile

All comments

Kumar Amit• 10

@kumaramit1947

Submitted over 1 year ago

Mobile first QR Code Component - HTML and CSS

Bernard Addy-Sackey• 230

@boypaida12

Posted over 1 year ago

Hi there Amit👋. Great job on completing this challenge. Here are a few suggestions to your code

For accessibility, it is important to include landmarks in your html document. Although this challenge may not seems like much, it is still good practice to implement them so you become accustomed.

In an html document the landmarks are the header, main and footer. To put into better perspective;

  <body>
       <header>
       /* your code */
      <header>
     <main>
       /* your code */
      <main>
     <footer>
       /* your code */
      <footer>
  </body>

In your situation the <div class = 'attribution'> should be within the footer landmark.

I hope this helps and happy coding!

Marked as helpful

Ismanol Garcia• 90

@ismanolgarcia

Submitted over 1 year ago

Single price grid component

Bernard Addy-Sackey• 230

@boypaida12

Posted over 1 year ago

Hi friend 👋

I checked your code and everything checks out except;

Why us <p>: Wrap reasons in a <p> tag rather than wrapping all elements in one.
Heading tags should increase by 1, as in <h1> <h2> <h3> and so on. Replace <h3> with <h2> in your code

Happy coding!