Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first QR Code Component - HTML and CSS

@kumaramit1947

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@boypaida12

Posted

Hi there Amit👋. Great job on completing this challenge. Here are a few suggestions to your code

For accessibility, it is important to include landmarks in your html document. Although this challenge may not seems like much, it is still good practice to implement them so you become accustomed.

In an html document the landmarks are the header, main and footer. To put into better perspective;

  <body>
       <header>
       /* your code */
      <header>
     <main>
       /* your code */
      <main>
     <footer>
       /* your code */
      <footer>
  </body>

In your situation the <div class = 'attribution'> should be within the footer landmark.

I hope this helps and happy coding!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord