I followed Florin Pop's Youtube tutorial for most of this but parted ways on a little of the CSS and HTML. A question: is this the only JavaScript solution for the email verification? It used some formulae that I was not familiar with so wondered if there was a simpler way.
Bgnichol
@bgnicholAll comments
- @bgnicholSubmitted over 4 years ago@bgnicholPosted over 4 years ago
BTW, some of the H1 and P text is not showing up in the snap-shot preview, because I used animation in the CSS. When the page is loaded, it centers.
0 - @bgnicholSubmitted over 4 years ago
Thanks for the challenge and the community feedback. I used CSS grid for the desktop version and flexbox for the mobile. I hope it worked out or at least came close. This is my first submission, so any pointers are greatly appreciated.
@bgnicholPosted over 4 years agoThanks so much for the feedback, Matt. I am just dipping my toe into media queries, so these are just the sort of pointers I need. I'll use the min-width from now on. Thanks again!
0 - @sahithyandevSubmitted over 4 years ago
Feedback wanted. Does the shadow on the cards look silly?
@bgnicholPosted over 4 years agoI just finished this one myself, Sahthyan. Great run at it. The flexbox looks good, but did you consider setting fixed sizes for the boxes with px? I found Florin Pop's walk-through to be a helpful starter before coding this project in my own style. You can find it here - https://www.youtube.com/watch?v=PcSUEo0P0GU&list=PLgBH1CvjOA63Xvt0BaeQ7zL4KXX96Wbgp&index=2&t=0s. BTW, did you code this as mobile first?
1 - @g4m3rm1k3Submitted over 4 years ago
This took me a while to get not sure if I'm using best practices, I haven't learned grid or flexbox yet.
@bgnicholPosted over 4 years agoIt looks like you are off to a good start here, Michael. I just finished this one myself. I found watching Florin Pop's walk-through to be helpful to visualize the process, before coding the project in my own style.
0 - @milan93djordjevicSubmitted over 4 years ago
Hey there,
Just finished my first challenge. I'd appreciate all the reviews from you guys. Especially the bad ones.
Repo https://github.com/milan93djordjevic/milan93djordjevic.github.io
Live https://milan93djordjevic.github.io/
-Briefly- I struggled with .jpeg design so I'm sure that some of the content (most of it) is not even close to pixel perfect. So while reviewing it please focus on "bad practices" or point out good ones and let me know. Looking forward to hear more from you.
Thanks, Milan D
@bgnicholPosted over 4 years agoThis looks good, Milan, and great work on accessibility. That is something I am working on, so it helps to see your code. Also, you laid out your grid in a different way than I had; it is helpful to see the alternative. The site looks good. A question: does your media query address mobile viewport size?
1 - @bgnicholSubmitted over 4 years ago
Thanks for the challenge and the community feedback. I used CSS grid for the desktop version and flexbox for the mobile. I hope it worked out or at least came close. This is my first submission, so any pointers are greatly appreciated.
@bgnicholPosted over 4 years agoThanks so much, Milan. I appreciate it. I also realized after posting that my images did not come across on Github. I will look into that too. I look forward to checking out your version.
0