Responsive using grid and flex box

Community feedback

• 

  Bgnichol•60

  @bgnicholPosted over 4 years ago

  This looks good, Milan, and great work on accessibility. That is something I am working on, so it helps to see your code. Also, you laid out your grid in a different way than I had; it is helpful to see the alternative. The site looks good. A question: does your media query address mobile viewport size?

  1

  ---

  

  Milan Dordevic•165

  @milan93djordjevicPosted over 4 years ago

  @bgnichol Thanks for positive review. I've added only max-width of 800px in queries; plan was to target smaller tablets and phones. I've downloaded second project and realized there's a style-guides file which I didn't use in this one... Beginners mistake... I don't know how I missed it the first time tbh... Anyhow on Four Cards Project says to use query for mobile 375px. Now you can stick to it but seems to me that design should break down to mobile on smaller tablets and all other smaller viewports... As for the grid, I like your version more - it's simple and efficient for this project. But in meanings of frontend web development I'd probably use 12 columns layout same as bootstrap does because you'll have more flexibility with it while working on "real life" projects. I don't know, maybe I'm wrong but (I'm not an expert...yet :D )

  1
• 

  Milan Dordevic•165

  @milan93djordjevicPosted over 4 years ago

  *I just realized I had style-guides file which I didn't use :'D

  0