Thanks in advance for any feedback. It's highly appreciated.
Rebecca
@bexicaaaAll comments
- @cjwelldoneSubmitted almost 3 years ago@bexicaaaPosted almost 3 years ago
Hy Stephan! This look very nice! I like how you did Javascript part with the less code as possible. I would suggest you use semantic Html, for example instead of <div> use <article> tag for widgets. :) It would be more accessible to users with dissabilities.
Marked as helpful1 - @Programming-School-Pro-CodingSubmitted almost 3 years ago
Feedback
@bexicaaaPosted almost 3 years agoAdd some padding-bottom to <p> tag on Patrick Abrams card to get more space. I suggest you use REM instead of px bcs when user sets different font-size on browser, REM automatically scale up and down elements like fonts, images etc on the webpage which is not the case with PX. Also you can center the content of testimonial grids using flexbox!
Marked as helpful0 - @alsirSubmitted almost 3 years ago
I struggled and get no where with trying to make the image in the intro to over flow to the top of the next container any advice or help??
@bexicaaaPosted almost 3 years agoCheck out the Coder Coder tutorial on youtube, she explains how to do it! If you want check out my code feel free to do so :)
Marked as helpful1 - @bexicaaaSubmitted over 3 years ago@bexicaaaPosted over 3 years ago
Thank you very much :) I will defenitely make some additional changes to the code. Have a lovely day!
0 - @bexicaaaSubmitted over 3 years ago
- @bexicaaaSubmitted over 3 years ago
- @grace-snowSubmitted about 4 years ago
This is designed to be a guide for one way to do this challenge mobile-first, using scss variables and some more advanced css techniques like nth-child.
I used a VS Code extension to compile the scss.
Note: In a real project I would work with the designer to fix the accessibility issues or color contrast and font sizes.
Any questions or suggestions are welcome.
@bexicaaaPosted almost 4 years agoHey Grace why did you put everything inside of a blockqoute? Is it possible to use div instead? :)
0