All comments

• 

  Csaba Hell•140

  @hellcsabaSubmitted 2 months ago

  What are you most proud of, and what would you do differently next time?

  I'm happy that I used semantic HTML5 in my solution whether I'm not a 100% sure that I used it at the best. Moreover, I learnt that the max-width css property can have fit-content value which can be useful for my future projects. Maybe next time it would be nice to try out the mobile design first approach.

  What challenges did you encounter, and how did you overcome them?

  I didn't know how to make the learning category tag's background properly. After research on the internet I found the fit-content value.

  What specific areas of your project would you like help with?

  I used semantic HTML5 markup, however I'm not sure in my solution. Would it be better to include the blog-image in the content section?

  

  Blog preview card

  1

  20
  

  ayx•60

  @ayx234Posted about 2 months ago

  Hello,

  Your code is well structured, and I only have minor notes:

  • Think of the design components in terms of their placements. This article card will be part of a page which will already have an <h1>. <h2> is better as a header for this card.
  • You included an overflow: hidden; for the body, but why would you want to hide a part of major page section?

  Marked as helpful

  0
• 

  Deepak Kumar•50

  @Deepak4511Submitted about 2 months ago

  

  qr-code-challenge

  1

  10
  

  ayx•60

  @ayx234Posted about 2 months ago

  Hello Deepak,

  I hope you find my feedback helpful.

  Looking at your solution I can see that your page scaled differently than the provided design. I had the same problem on my first submit! Try displaying the design images using the original dimensions (375 x 812)px for the mobile design, and work on the measurements from there.

  I also see that you included the "Outfit" font on your CSS. It doesn't display because you didn't include the required <link /> tags on your HTML. On the font's URL: https://fonts.google.com/specimen/Outfit click on the shopping cart icon (top right) then click on "embed code." On the page that opens you'll be able to copy the required tags.

  Marked as helpful

  1