@avinashdhauni
@DorisSch15
Submitted
Hope to get a lot of feedbacks from all of you. Still working to be better at javascript. Thanks for your help !
Oh yeah and I need to point out that I only did the desktop version :) I know, it's mobile first but I needed a good feeling when creating the HTML/CSS part and an AHA moment with the Javascript.
@avinashdhauni
Posted
Hello Doris, I noticed a little problem with the project. When you click in between numbers, like for example- between 2 or 3, or maybe 3 or 4, etc then all the numbers are being selected. And after that, if you click submit then all the numbers are shown on the Thank You component. I don't know what the issue is because you seemed to have used webpack and other stuff that I am not familiar with. And also I guess you forgot to give hover effects to the submit button as well. But congratulations on completing the challenge. Happy Coding!
Marked as helpful
@kennyoyaf
Submitted
I have problems sometimes with the sizing of some element in different screen because some elements in things I build change shape when in different screen sizes
@avinashdhauni
Posted
Your main-container box is too wide. You can give your .main-container a width of 30% or something. Or you can give a fixed width of 330px to the .main-container. Also, I noticed you haven't changed your font. The given font in the challenge is Overpass. But congratulations on completing the challenge
Marked as helpful
@DevWanderson
Submitted
The part of centering the card became a little complex for me, I found a solution but I feel I could have done it more effectively
improvement suggestion?
@avinashdhauni
Posted
Hello, I guess you forgot to make your project responsive. Also, there is an issue with your line-height on the paragraph. Image width should take up to 50% of the space. There is slight difference with your design and the given design. Also the font size could be smaller. But congratulations on working and completing the challenge
Marked as helpful
@MarcosRubi
Submitted
@avinashdhauni
Posted
Amazing Functionality Bro. You have done amazing work. You are good at Javascript. Hope to connect with you. You have written great Javascript Codes. I didn't know you could build something called Modal in Javascript. I built that functionality using HTML and hiding it. It's a learning experience for me to see your codes. Especially the modal one and the eventListeners. I loved the use of forEach for using Event Listeners. You are amazing dude. Keep it up. I am just a beginner and these codes might be basic, I don't know. But I learnt a lot and that is why I am writing this. Also, I forgot to tell you that I guess you forgot to reset the form because the continue button doesn't work. Other than that everything is amazing.
