All comments

• 

  Rohit Kumar•560

  @rohitKumar38344Submitted almost 2 years ago

  any feedback is appreciated :D

  

  preview card component

  1

  10
  

  asekabtw•290

  @asekabtwPosted almost 2 years ago

  Hello Rohit Kumar! You have handled this challenge! I have some tips for ya:)

  1 Advice I think You can put the footer with class attribution inside the section. And give section position relative and to attribution position absolute.

  2 Advice Or You can just give min-height: 95vh to section and min-height: 5vh to footer. I don't know really would it work, but I guess it will.

  Great job!!! Happy coding!

  0
• 

  Rostyslav Nazarenko•560

  @rostyslav-nazarenkoSubmitted almost 2 years ago

  Hello! I'd love your feedback 😁

  • I had a few problems with doing the hover effect. I'm not sure how to do it properly if there's some other way to do this, please tell me.
  • How do you name your classes? Do you use BEM? Did I use BEM right?

  

  NFT preview card using HTML, CSS, Flexbox, transitions

  3

  60
  

  asekabtw•290

  @asekabtwPosted almost 2 years ago

  Hey Rostyslav, great jobbb))) I made hover effect like you, but a little bit different:

  1. I made it all together in :after element. I set to the background-image icon svg. And I put the background-color in :after element. So when i hovered to that image I changed only opacity from 0 to 1.
  2. Name classes on their own. If you think the div with class will have it's elements, name without parent-name. For example: Create a div with class card. Inside this card you can create elements like card__title, card__description and etc. And within this card class you can create a div with class "image". And name it's elements like image__item, image__title, etc. You don't need to name everything like their parent element. Block element modifier. Just create a block and inside of this block it's element. Also you can create more block inside of that block.

  I really tried my best to explain to you. I hope I helped you a little. Keep doin' I wish you the best!

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  byp28•40

  @byp28Submitted almost 2 years ago

  All feedback is welcome thank you in advance

  

  Product preview card component

  2

  40
  

  asekabtw•290

  @asekabtwPosted almost 2 years ago

  Hey @byp28! Awesome job. I have some advices for you:

  1. You can change the div with class card to main with class card. Because you don't have any other content beside that.
  2. I really recommend to start Responsive design with mobile first. It will be easier to change the after (not all the time ofc). But most of the time it will be easier.

  Im not a professional, but I hope I helped with something) Keep going!

  Marked as helpful

  0
• 

  MerMory-Alloc•250

  @MerMory-AllocSubmitted almost 2 years ago

  writing concise and clear CSS is difficult because it require a good understanding of CSS attributes on which i learned in this simple exercise.

  

  Product-preview-card-component-solution

  1

  40
  

  asekabtw•290

  @asekabtwPosted almost 2 years ago

  Hello, @MerMory-Alloc! Good job. I mean really good job. I have some advices for you:

  1. You can put class container inside of the main tag.
  2. Try to use method called BEM. If you don't know what is it, you can read it here: https://getbem.com/introduction/
  3. Try to write text in p or h tags. You can change div with class category to p with class category and it will be easier, because perfume is not doing any role of some kind of link or etc.

  I Hope I could help you. Even a little. I am not a professional and I am not 100% correct, so take it as a friend tip)

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Frank Oguche•320

  @FrankmonaSubmitted almost 2 years ago

  1. importing the right font-style
  2. Styling the button

  

  used external css

  1

  10
  

  asekabtw•290

  @asekabtwPosted almost 2 years ago

  Hey buddy, great job! Just keep doin'. I have some advices for you:

  1. Instead of div with class main, use main with class main or content or whatever you want.
  2. Try to get rid of white spaces in your code. Keep your code clean.
  3. Instead of div with class footer, use footer with class attribution or smth else.

  But you are doing really great job. Just keep going. You will achieve your goals. Don't ever give up.

  Marked as helpful

  0
• 

  iulso•90

  @iulsoSubmitted almost 2 years ago

  

  QR Code Component using CSS custom properties and BEM methodology

  1

  20
  

  asekabtw•290

  @asekabtwPosted almost 2 years ago

  Hey great job! You can improve your code by changing:

  <div class="content"></div> into ---> <main class="content"></main>

  Also you can add comments before classes and after closing them, because it will help to work with bigger projects. For example:

  <! -- Content -->

  <main class="content"> some kind of content </main> <! -- End of Content -->

  0