Arash Kazerouni
@arashKazerouniAll comments
- @for-dev9Submitted almost 2 years ago@arashKazerouniPosted almost 2 years ago
Hello there! everything is good i love the way that you named your classes just focus a little bit more on Semantic HTML. for example, you could use section instead of div for content. or instead of this :
<div class="social"> <button id="btnFb" class="btnSocial"> <i class="bi bi-facebook socialIcn"></i> </button> <button id="btnTw" class="btnSocial"> <i class="bi bi-twitter socialIcn"></i> </button> <button id="btnIg" class="btnSocial"> <i class="bi bi-instagram socialIcn"></i> </button> </div>
you could just do this :
<aside class="social-icons"> <img src="./images/facebook.svg" alt="facebook logo" /> <img src="./images/twitter.svg" alt="twitter logo" /> <img src="./images/instagram.svg" alt="instagram logo" /> </aside>
keep things as simple as you can. please separate your CSS from HTML. use more comments in your code and practice and practice ;)
1 - @catherineisonlineSubmitted almost 2 years ago
Hello, Frontend Mentor community! This is my solution to the Huddle landing page with alternating feature blocks.
I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
@arashKazerouniPosted almost 2 years agoCongratulations! this is exact the same as desired design!! my solutions always have some differences with original design(even small differences, but your solution is completely fit). how did you do this?
0 - @itsnooshinSubmitted over 2 years ago@arashKazerouniPosted almost 2 years ago
i think a little bit of letter spacing in text under number needed. its better to use more clear names for your classes. learn more about semantic HTML, you could use article instead of section. i hope my feedback is helpful mt friend. by the way, you are doing great job. keep going!
0