Skip to content
OverviewSolutions
3
Comments
4
Anisha Murthy
@anishamurthy

All comments

  • Ola•520
    @Great-kiolaSubmitted over 1 year ago

    The only thing im missing is the focus state, casue it didnt work when i added it, is there any help i can get on that?

    Interactive-rating-comp

    1
    Anisha Murthy•60
    @anishamurthyPosted over 1 year ago

    Hi Ola, I have some feedback that may be useful for you. For setting colors, don't use color names because different browsers may not agree with what certain color names mean. Instead of div tags for the rating selection, you should use a form tag for all the rating selections and the submit button. You can create radio buttons for all of the rating selections, and use the javascript onfocus event for each rating to set the focus state.

    Also, for scalability don't set a height for the main container and use em or rem for font size, margins, and padding. Don't set fixed heights and widths in px.

    For line height, make sure you do not use px for line height and use a unitless measure like 1.5. Unitless line heights are recommended due to the fact that child elements will inherit the raw number value like 1.5, rather than the computed value of the parent's line height. The child element can compute its line height using its font-size, rather than a random inherited value from a parent that might need overriding.

    You can use a CSS reset like https://andy-bell.co.uk/a-modern-css-reset/. You can also use a code formatter like Prettier.

    If you use a linear gradient, you should set a regular background color before in case the linear gradient does not work.

    Overall good job!

    Marked as helpful
    0
  • Anisha Murthy•60
    @anishamurthyPosted over 1 year ago

    Hi, I have some feedback that may be helpful to you. Make sure you add an alt text to your image, in this case, mention that the QR code links to a URL, for example, Qr code for the URL(insert URL). Make sure you add a main tag, which adds semantic meaning by specifying the document's main content. Also, add a footer tag. As for the shadow, I don't think it is specified. Your solution looks great!

    Marked as helpful
    0
  • Anisha Murthy•60
    @anishamurthyPosted over 1 year ago

    Hi, ensure you add a main tag to your HTML and don't use an h6 tag, start with h1 instead. the h1 tag is the most important heading on the page. You should add alt text to your image by mentioning the URL the QR code links to, for example, QR code for the URL(insert URL). Alt text should always be added to non-decorative images that are meaningful to the page. You can add a CSS reset of your choice as well, for example, https://andy-bell.co.uk/a-modern-css-reset/. You can use a code formatter like prettier. Congratulations on completing the challenge you submitted a great solution!

    1
  • Anisha Murthy•60
    @anishamurthyPosted over 1 year ago

    Your solution looks good! Make sure you include a main tag either as the card or wrap it around the card. Also, you should use em for font size to make it scalable for smaller screens.

    0