All comments

• 

  isamardzija• 280

  @isamardzija

  Submitted almost 2 years ago

  

  QR Code Component using Flex

  1

  10

  

  Anh Tuấn Bùi• 240

  @anhtuanbui

  Posted almost 2 years ago

  Hi there,

  Congratulations on completing the challenge! There are a few things that I want to point out that I think would help you to improve the code and the component.

  • There should be an alt tag for the QR code image. There should be a main tag to embrace the container div. And the card title could be an h1 tag.
  • The additional info that shows author should be out of the card, in a footer tag.

  Happy Codding. Cheers!!! 👉✨🌝

  Marked as helpful

  0
• 

  maxencetsln• 100

  @BikoiFr

  Submitted almost 2 years ago

  I did something strange with js for the mobile menu

  

  News Homepage

  1

  40

  

  Anh Tuấn Bùi• 240

  @anhtuanbui

  Posted almost 2 years ago

  Hi there

  You've got the solution there. However, I noticed some places that you can improve for your code.

  • Remove issues from the report you can use a main tag instead of the wrapping div. Put alternative text for all images
  • The main flexbox you can have flex: 1 1 70%, the right bar can have flex: 1 1 30%, gap: 2rem. The last section can have display:flex and gap: 2rem. It will solve the collumn problems

  Happy Codding. Cheers!!! 👉✨🌝

  Marked as helpful

  0
• 

  Nenad Cosovic• 360

  @nenadmne

  Submitted almost 2 years ago

  

  Interactive web

  2

  40

  

  Anh Tuấn Bùi• 240

  @anhtuanbui

  Posted almost 2 years ago

  Hi Nenad,

  Your solution is looking good. But I noticed some things that you might want to change to fit the design:

  • The background around numbers should have same height and width so it's round when you use border-radius: 50%. This happened the same on the star.
  • You should increase boder-radius of the submit button so it is the two sides are round

  Happy Coding

  1
• 

  Alex• 50

  @alexvdc

  Submitted almost 2 years ago

  Is this good enough ?

  Any feedback are welcome !

  

  news-homepage-main

  3

  40

  

  Anh Tuấn Bùi• 240

  @anhtuanbui

  Posted almost 2 years ago

  Hi Alex,

  Your solution look good. However, there are some things that you may want to improve.

  • Your grid, your third section does not align well with the one above.
  • Your images are not fitting well. You can use object-fit: cover for images.
  • Your background color in the middle is different from two side.

  0

  This comment has received 1 replyShow