Skip to content
OverviewSolutions
11
Comments
4
Aneta
@anetaanette

All comments

  • Guillermo•170
    @Guille2000Submitted almost 3 years ago

    So, re-started my studies with front end and so i completed this challenge. I used all knowledge i have to create a website the best way possible. This proyect has BEM, SASS, MIXINS, and its responsive! Please, any feedback would be apreciate it

    Responsive Page with SCSS, BEM, Mixins

    1
    Aneta•180
    @anetaanettePosted almost 3 years ago

    Hey! Nice job, I like it! There are a few things you can change if you want to match better the initial project (although that's up to you, maybe you prefer the way it is now ;) ):

    • The buttons have shadows and border-bottom, the font is bold
    • The left side of the screen is cut and the text next to it is narrow, basically it wraps at some width
    • The logo is smaller and doesn't float to the left Keep working! Happy coding :D
    Marked as helpful
    0
  • Zulfikar Muhamad•290
    @zulfikar321Submitted almost 3 years ago

    I think it's a challenge that makes me difficult. Especially in the use of javascript on to display results in carts using innerHTML, it's true" makes me troublesome, and maybe my code is also very messy especially in css, if you have suggestions, write in the comments

    E commerce product page HTML, CSS, & Javascript

    1
    Aneta•180
    @anetaanettePosted almost 3 years ago

    wow great job!

    1
  • Aneta•180
    @anetaanettePosted almost 3 years ago

    Hi, good job! A few things you could improve:

    1. the whole card is a bit too big, maybe you could make it smaller to fit the whole card without scrolling.
    2. The "Jules Wyvern" text should change the colour to cyan when hovering too.
    3. The whole "creation of Jules Wyvern" text should be on the side of the avatar, not underneath.
    4. You can change the link to your github or frontend mentor profile in the footer. Overall, good job :) Happy coding! Aneta
    Marked as helpful
    0
  • Aneta•180
    @anetaanettePosted almost 3 years ago

    Hey, congrats, it looks great! One thing I'd add is display flex in body and then justify-content and align-items to center. This would place the whole container in the center. Let me know if it worked.

    0