Design comparison
Solution retrospective
hi guys please requesting for feedback kindly take your time to view my work
Community feedback
- @anetaanettePosted almost 3 years ago
Hi, good job! A few things you could improve:
- the whole card is a bit too big, maybe you could make it smaller to fit the whole card without scrolling.
- The "Jules Wyvern" text should change the colour to cyan when hovering too.
- The whole "creation of Jules Wyvern" text should be on the side of the avatar, not underneath.
- You can change the link to your github or frontend mentor profile in the footer. Overall, good job :) Happy coding! Aneta
Marked as helpful0 - @rsrclabPosted almost 3 years ago
Hi, @DrMESAZIM ~
Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it. Especially I like the image overlay effect on your project. Especially I like BEM structuring on your project.
Here are some of the tips I like to provide.
- Image overlay border-radius is missing.
- I suggest you to try transition on hoverable elements like heading and creator name.
- Please try BEM for naming element classes. It will help you a lot on bigger projects.
- Alignment and spacings aren't the same with design. As a front-end developer, it's important to meet pixel-perfect requirements.
- Image tags must have alt attributes as standard.
https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH
Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.
Cheers ~
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord