Amr_Hesham
@amooriheshamAll comments
- @joaovxsantosSubmitted almost 2 years ago@amooriheshamPosted almost 2 years ago
Great work my friend
Here's some things to edit i hope you found it useful for you. You need look back at the font-size it's need to be increased. you set the body height to 100vh which will limit your content to be set in this height which also will make a trouble in small screens so give the body min-height as 100vh to make it's content height adapt as the need of content to show it decent in small screens.
I hope you found that useful keep cool stuff
Marked as helpful0 - @Sonya-cSubmitted almost 2 years ago
- @EdoPitoSubmitted almost 2 years ago
My solution for the Social proof, any feedback is always welcome.
@amooriheshamPosted almost 2 years agoGreat work buddy. Here's some tips to enhance your design. Give your top section some
margin-bottom
to make room to split between top and bottom. In bottom you can give your flex somegap
to also separate between the 3 boxes. I recommend you to read more about align items using flexboxThat's pretty much it Happy night
1 - @AhmedAlkhSubmitted almost 2 years ago
I was unable to make the image div and the information div the same size so there is a slight difference at the bottom where they should be flush. I would appreciate any help in fixing this issue along with any others that are spotted. Any feedback is appreciated, thanks in advance!
Edit: Changes from feedback have been implemented.
@amooriheshamPosted almost 2 years agoGreat work my friend.
Here's some notes to be know you design looks decent on desktop although in Mobile screen it's unusable. So my advice to get back and tweak the code to make it work in other screen and to read more about media queries. For your question about the image bottom area you can go with set the display of block Or give the image height 100% which will solve that issue too. Keep coding
Marked as helpful0 - @smavilpSubmitted almost 2 years ago@amooriheshamPosted almost 2 years ago
Great work my friend.
Here's some tips which i hope you accept that from a newbie. You can give the div with
.main
some padding in bottom to make space between the footer. You but you bottom area in side a footer to solve the accessibility issue. And that's it keep the great work.Marked as helpful2