Before this, I avoided using grid like the plague, and this was pretty hard for me. Watched a video on grid and was able to do it, but the scales are probably all over the place and the code is not neat at all. Anyways, it was enjoyable, and i will definitely use grid more often.
Alexandru Stroe
@alstrowAll comments
- @TheTrueScoutSubmitted about 2 months agoWhat challenges did you encounter, and how did you overcome them?
- @Fbeye04Submitted 2 months agoWhat are you most proud of, and what would you do differently next time?
The proudest thing is that I've gotten better at writing media queries including getting used to starting a mobile first workflow and another thing is that this is the first time I've used SASS instead of CSS.
What challenges did you encounter, and how did you overcome them?The most difficult challenge I felt was the migration from CSS to SASS because it took time to learn it, besides that the styling of cards that have a special color at the top of the card also provides its own challenges for me.
What specific areas of your project would you like help with?all area of html and css
- @DORMODOSubmitted 5 months agoWhat specific areas of your project would you like help with?
Could you take a look and give me your opinion?
@alstrowPosted 4 months agoIt looks great, congrats!
You forgot the icon in the button and maybe a little
letter spacing
in the.product__type
. Also, that sould be a simple paragraph, not really the main title :)0 - @AlperenGrmzSubmitted 4 months ago@alstrowPosted 4 months ago
Congratulations for completing the challenge, it looks very good!
A little advice, you could add lateral padding in the
body
, so that the main does not touch the edge, or add a max-width on the.main
of 40-50 rem.Keep going! ^^
0 - @ahmedraza032Submitted 4 months ago@alstrowPosted 4 months ago
@ahmedraza032 Hey, congrats on completing the challenge, looks good! however, here are some tips that I hope you find useful:
- Those buttons should be links that lead the user to the related pages. you can achieve this using the a tag:
<a href="#">LINK</a>
- In the case of
.link:hover
, you could put the 2 properties inside the single brace
Happy coding! ^^
Marked as helpful1 - Those buttons should be links that lead the user to the related pages. you can achieve this using the a tag:
- @ajay-8192Submitted 4 months ago@alstrowPosted 4 months ago
Congrats on completing the challenge, looks great!
A small tip I have would be to add
padding
to thebody
element. This ensures that the center element does not touch the edges on smaller screens.Happy coding!! :)
1 - @uzairsaleem36Submitted 4 months ago@alstrowPosted 4 months ago
Hey
Congrats on completing the challenge. It looks very good and I like it, here are some things you could improve:
- You should add another text to images
<img src="source" alt="text">
. This helps both the search engine and the user, in case the image cannot be displayed - You could adopt a sleeker design by adding spaces between the elements in
<div class="mini-2">
. In CSS you can add the gap property:
.mini-2{ display: flex; flex-direction: column; gap: 1.5rem; }
- One last thing, is the
:hover' state after the element that you want to have special properties when the user hovers over it. In the original design, the title
<h3>HTML & CSS Foundations</h3>` changes color when hovered in yellow. you can achieve this using:
.mini-2 h3{ font-family: 'MyCustomFont'; color: black; margin-top: 8px; } .mini-2 h3:hover{ color: yellow; }
I hope you will receive my feedback as a helper and good luck with the next projects :)
Happy coding!!
Marked as helpful0 - You should add another text to images