All comments

• 

  P

  a-woodworth• 290

  @a-woodworth

  Submitted about 2 years ago

  Hi everyone! 👋

  Wrapped this challenge up yesterday but just now posting. Built this using CSS Grid and JavaScript. Was a nice challenge working with object data.

  A couple of the colors did not pass color contrast ratios so I swapped them out for ones that did.

  

  Time Tracking Dashboard with CSS Grid, JavaScript

  1

  50

  

  Allyson S.• 190

  @allyson-s-code

  Posted almost 2 years ago

  Just wanted to say thanks so much for posting. I was having trouble getting into the JS portion because it's been a while and after looking at a few different ones yours really made the most sense to me and helped me out tremendously. It's very clear and concise.

  0
• 

  Allyson S.• 190

  @allyson-s-code

  Submitted about 2 years ago

  

  Fylo Dark Theme Landing Page

  1

  30

  

  Allyson S.• 190

  @allyson-s-code

  Posted about 2 years ago

  Hi! I would love it if someone would take a peek at my HTML and give feedback. I received an error that:

  Element figcaption not allowed as child of element div in this context.

  (I used it in the testimonials section). Any ideas on how to improve my HTML overall to make it more semantic and accessible?

  Thanks so much!

  0
• 

  EngrHumza• 10

  @EngrHumza

  Submitted over 2 years ago

  Wich technique you use to transfer the data from rating component to thnakyou page?

  

  html,css,js

  2

  30

  

  Allyson S.• 190

  @allyson-s-code

  Posted over 2 years ago

  Hi, I think your app looks good. I would recommend adding <button> and/or <input> tag for the rating buttons and submit button. It is helpful for accessibility.

  I ended up adding a value class to the ratings buttons and grabbed that in my JavaScript function for updating the text on the thank you page. You are welcome to take a look at my solution code if it's helpful. https://github.com/allyson-s-code/interactive-rating-component.

  Great work! Allyson

  0
• 

  Marcin Garski• 350

  @margsoftbf

  Submitted over 2 years ago

  The next challenge, which i finish. Now im focused on the JS so i try working with challenge which have the JS. If someone see something wrong or what i can do better it will be great for me.

  

  Frontend Mentor - Advice generator app solution

  2

  40

  

  Allyson S.• 190

  @allyson-s-code

  Posted over 2 years ago

  I think it looks great! I thought your code was easy to read, too.

  I have to say I was overcomplicating matters with my own version of this project with the two sizes of svgs. I was reading about viewbox (for way toooo long) and trying a javascript function for the change in media size. Your solution is simple, just css display: none and display: block. Perfect! It is so helpful looking at other peoples code!

  Well done!

  Marked as helpful

  0