Frontend Mentor - Advice generator app solution

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 👍

  keep improving your programming skills

  your solution looks great, however, if you want to improve it, you can follow these steps:

  🟢 your initial layout has no advice number. It looks as bug)

  🟢 try to follow a single code style throughout the program. In almost all places you use arrow functions, and only for handle the fetch request - the usual anonymous function. Also try to use destructing.

  .then(({slip}) => {
      const {id, advice} = slip;
      titleId.textContent = id;
      randomText.textContent = advice;
  })
  

  Looks more cleaner, right?

  🟢 Change id class to box__id instead of box__title--id, because it's not a modificator

  I hope my feedback will be helpful

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  1

  ---

  

  Marcin Garski•350

  @margsoftbfPosted over 2 years ago

  @isprutfromua Thanks, for help i changed everything what you said. Thanks a lot :)

  0

  

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  @margsoftbf Hi there

  I'm glad it was useful to you

  Cheers, peace and happy coding!

  0
• 

  Allyson S.•190

  @allyson-s-codePosted over 2 years ago

  I think it looks great! I thought your code was easy to read, too.

  I have to say I was overcomplicating matters with my own version of this project with the two sizes of svgs. I was reading about viewbox (for way toooo long) and trying a javascript function for the change in media size. Your solution is simple, just css display: none and display: block. Perfect! It is so helpful looking at other peoples code!

  Well done!

  Marked as helpful

  0