Skip to content
OverviewSolutions
42
Comments
6
alfred thompson ovie
@alfredthompsonOvie

All comments

  • alfred thompson ovie•820
    @alfredthompsonOviePosted over 2 years ago

    Nice work

    1
  • alfred thompson ovie•820
    @alfredthompsonOviePosted over 2 years ago

    By inline styles, do you mean using the style attribute on HTML elements?? It's bad practice, because (1) you're not considering separation of concern, and (2) it increases the specificity of that element thereby making it more difficult to change the styles from your CSS style sheet

    1
  • Mr Skyner•30
    @MrSkynerSubmitted over 2 years ago

    Hello! This is my solution for the project named Stats Preview Card!

    Any feedback it's helpful! Thanks for checking and feedback!

    Stats Preview Card

    3
    alfred thompson ovie•820
    @alfredthompsonOviePosted over 2 years ago

    Hi Mr skyner, looks nice, but you could do with a little bit of padding to the contents

    1
  • Dhruv•60
    @dhruv28o1Submitted over 2 years ago

    your feedback helpes me to improve..... improved some components of code.... give your feedback i will try my best to improve more.......... thankyou.....

    product preview card

    3
    alfred thompson ovie•820
    @alfredthompsonOviePosted over 2 years ago

    Hi Dhruv, looks good, well done, but you could make the amount and button a little bigger

    0
  • alfred thompson ovie•820
    @alfredthompsonOviePosted over 2 years ago

    looks good

    1
  • Marija Havaic•150
    @marijahavaicSubmitted over 2 years ago
    • How do you name your classes and is there any naming convention I could follow?
    • Is it better to have a descendant combinator (body p) or class (.text) for styling?

    Order summary card solution

    4
    alfred thompson ovie•820
    @alfredthompsonOviePosted over 2 years ago

    There are a couple of naming convention you can follow, but i could suggest using BEM..

    I always take specificity into account when choosing between classes, IDs or descendant selector because i aim to reduces the specificity as much as I can

    Marked as helpful
    1