Design comparison
Solution retrospective
Hello! This is my solution for the project named Stats Preview Card!
Any feedback it's helpful! Thanks for checking and feedback!
Community feedback
- @realsalePosted over 2 years ago
Yo! @MrSkyner,
Congrats submitting your solution for this design.
The obvious thing that might need refinement is your alignment, I've noticed you haven't use
flex
norgrid
and hardly relied onmargin
and some fixed dimensions.I recommend you to try and learn
flex
and/orgrid
as these are the modern layout approach Beginners guide to flexbox | Beginners guide to gridAlso you don't have to explicitly define the containers
height
, Just set the similarwidth
as the design, and let the image take the half of it and leave imageheight: auto
, This will keep the image properaspect-ratio
Marked as helpful1 - @purnimakumarrPosted over 2 years ago
Hi Skyner, your solutions look really good. But it isn't centered properly. Here's what you can do..
body { height: 100vh; display: grid; place-items: center; }
And get rid of the margin on the card component.
1 - @alfredthompsonOviePosted over 2 years ago
Hi Mr skyner, looks nice, but you could do with a little bit of padding to the contents
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord