Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Zach Kyman 220

    @zky63

    Submitted

    I feel like the code is a bit sloppy and could be reduced but since I am relatively new I just wanted to see if I could match the provided document by whatever means necessary. Please let me know where I could clean it up.

    Thank you.

    Alan 335

    @alanhcrdz

    Posted

    Hi Zach, your solution looks nice, congratulations!

    To let more clean, try to do these things:

    -Change your <div>your text</div> tags for <p></p> tags, like below:

    <div id="likesCount" class="boldText infoBig">803K</div>
     <div id="likesText" class="lightText infoSmall">Likes</div>
    

    Since the paragraph <p> is more appropriate for a good semantic HTML, is a good idea to not use so many divs.

    • You can play with box shadowing in your card, test which looks good for your project.

    -Also fix the accessibility and html issues.

    Keep going.

    1
  • Alan 335

    @alanhcrdz

    Posted

    Hi Martinien,

    Your solution looks nice! Here are some details I would like to share with you to Improve:

    • You can add some transitions on hover for the buttons, will look soft and elegant.

    • For box shadow, I usually use a kind of dark transparent color, to get closer to the design.

    • For your text, some light grey color will look nice too.

    • Fix the accessibility and HTML issues

    Good job on your solution, keep going!

    0
  • Alan 335

    @alanhcrdz

    Posted

    Thank you! it's great to have your feedback, looks like I've yet missed some details.

    0
  • Alan 335

    @alanhcrdz

    Posted

    Hello Matheus, in your even listener for "click", add the element (e), then e.preventDefault();

    Try this and see.

    1
  • Alicja 40

    @alicjaplacz

    Submitted

    I would highly appreciate any feedback on the code, I have been coding only for a bit over a month and it would be great to hear from some experienced programmers.

    Alan 335

    @alanhcrdz

    Posted

    Hi Alicja, congratulations on your solution! There are three things I'd improve:

    • Try to resize your .form-container, the width seems to be a bit larger.

    • Add some padding to .input[type=text], email and password, 10px would be nice.

    • Fix the HTML and Accessibility issues.

    Keep doing great!

    0
  • Alan 335

    @alanhcrdz

    Posted

    Good job, Andrew. Here are some suggestions:

    • Maybe you can change the card's color to white.

    • The span texts also need colors, the colors are detailed on style-guide.md

    • Try to add some blur on you [box-shadow] and put some light color on them.

    • Change the [max-width] of .team and .karma to 300px, so it will be equals the others.

    Well done.

    2
  • Alan 335

    @alanhcrdz

    Posted

    Your box seems to be a little bigger than the original, but the design looks good. Try to put some border-radius and box-shadow also. Good job.

    0