All comments

• 

  merii•80

  @merii-crlSubmitted over 1 year ago

  I would love to hear your feedbacks If you have one, Thanks!

  

  Interactive rating component using html,css, and JS

  3

  70
  

  Ana•70

  @akajfesPosted over 1 year ago

  Hello! Looks really well done :) I would just say that when doing your html, you have a <p> with a class of "heading". It would be better if that was an actual h1 instead, as when you do HTML validation, it will ding you for not having a section with a heading element. I recommend using something like https://validator.w3.org/nu/ in order to check to make sure your HTML is valid! Other than that, good job :D

  Marked as helpful

  0
• 

  smlamod•10

  @smlamodSubmitted over 1 year ago

  I'm currently trying to improve my front-end skills; I would appreciate some feedback when it comes to CSS best practices and if i can do better with the html elements that I have used.

  

  Vanilla QR code component

  1

  40
  

  Ana•70

  @akajfesPosted over 1 year ago

  Hello! For the HTML markup, with the Google fonts, you want to load the fonts before you load the style sheets and also make sure to load the preconnect links as well, as that will help the page load faster. Also, you don't have to add class attributes to every single element, as it can result in the code being more bloated. For example, with an h1, you typically only ever use it one time, so you don't really need to identify it with a unique class name when you're just using HTML and CSS.

  Great job :)!

  Marked as helpful

  1