Skip to content
Submitted over 1 year ago

Vanilla QR code component

smlamod•10
@smlamod
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm currently trying to improve my front-end skills; I would appreciate some feedback when it comes to CSS best practices and if i can do better with the html elements that I have used.

Community feedback

  • Ana•70
    @akajfesPosted over 1 year ago

    Hello! For the HTML markup, with the Google fonts, you want to load the fonts before you load the style sheets and also make sure to load the preconnect links as well, as that will help the page load faster. Also, you don't have to add class attributes to every single element, as it can result in the code being more bloated. For example, with an h1, you typically only ever use it one time, so you don't really need to identify it with a unique class name when you're just using HTML and CSS.

    Great job :)!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord