Skip to content
OverviewSolutions
10
Comments
2
P
Adniya Yousaf
@adniyaYousaf

All comments

  • Adniya Yousafā€¢200
    @adniyaYousafPosted over 1 year ago

    Hello there šŸ‘‹. Congratulations on successfully completing the challenge! šŸŽ‰

    I have other recommendations regarding your code that I believe will be of great interest to you. BODY MEASUREMENTS šŸ“:

    Use min-height: 100vh for the body instead of height: 100vh. Setting the height: to 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation. For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of the viewport. But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However, if you have content that takes less than 100vh it will still take 100vh in space. .

    I hope you find this helpful šŸ˜„ Above all, the solution you submitted is great!

    Happy coding!

    0
  • christopherā€¢190
    @umahichristopherSubmitted over 1 year ago

    am a beginner in HTML and CSS. I can not find the background image or color so I use a color similar to it. pls, I need someone to guide me through. I try making it responsive but I couldn't ... please I need someone I can call my mentor pls

    i use grid and flex box

    1
    Adniya Yousafā€¢200
    @adniyaYousafPosted over 1 year ago

    Some recommendations regarding your code that could be of interest to you.

    <div class="footer"> with the <footer class="footer"> tag. You'd better use Semantic HTML, and you can also get more information about it by Using Semantic HTML Tags Correctly.

    I hope I have been helpful. :)

    Marked as helpful
    0