Design comparison
Community feedback
- @adniyaYousafPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you. BODY MEASUREMENTS 📐:
Use min-height: 100vh for the body instead of height: 100vh. Setting the height: to 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation. For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of the viewport. But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However, if you have content that takes less than 100vh it will still take 100vh in space. .
I hope you find this helpful 😄 Above all, the solution you submitted is great!
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord