@Msindy
Submitted
I have difficulties with working out media queries. I cannot seem to figure it out.Feedback is highly appreciated
@adeleke5140
@Msindy
Submitted
I have difficulties with working out media queries. I cannot seem to figure it out.Feedback is highly appreciated
@adeleke5140
Posted
Hi Misindy, great submission.
I looked through your codebase and it seemed that the styles for the heading
and text
did not apply. This is in reference to the font-weight
and width
properties. Also it doesn't seem like the font-family
was applied. You should check them and see why they aren't working.
What do you need help with in regards to media queries?
Marked as helpful
@clarencejulu
Submitted
What do you think of the project design and structure?
Any feedback is welcome, Thank you!
@adeleke5140
Posted
Hi Clarence, Your readme is very detailed. Great work on that.
I checked out your repo and I saw that you pushed your node_modules
folder to github. It's always recommended to ignore the node_modules
folder.
To do that for your next project, ensure you add /node_modules
in your .gitignore
file.
Marked as helpful
@MarcinFiuk
Submitted
@adeleke5140
Posted
I visited the preview link and an error keeps showing. It says: "I'm Sorry But Something Went Wrong. Code:0"
What could be wrong? if you feel like sharing, I'd be willing to help out.
@ovie009
Submitted
I just wanted to know if we are allowed top make slight modifications to the design, I included a sort dropdown and scroll to top button because I felt there were necessary, just wanted to be sure if we are allowed to do that?
@adeleke5140
Posted
Of course, you are allowed to make as many modifications as you like.
@cbserra
Submitted
react-select
components was very tedious@adeleke5140
Posted
Great project.
A couple issues I noticed from the live preview are:
You mentioned using React-select, how about trying out the native HTML select form control?
Marked as helpful
@BryanFonseca
Submitted
Besides my poor organization, what do you think could be better? I think using Redux could have been a good choice.
@adeleke5140
Posted
Have you tried looking into the HTML and accessibility issues that was generated??
They are one way of improving your webapp. And Redux might not really be necessary unless you need that global state. In my attempt, I used prop drilling but moving forward, I'd be employing Context to keep things clean and readable.
Marked as helpful
@EnjegheO
Submitted
I would appreciate if I'm given suggestions on better ways to set the background images for the body and how I can use percentages instead of pixels to set the sizes and positions of the background images. Also, general feedback would be appreciated.
@adeleke5140
Posted
I don't really know how to explain the percentages stuff because all I did was mess around with the values and it kinda worked. why is it stretched out though?
You can also check my github for the background solution https://github.com/adeleke5140/profile-card-component
@mj305
Submitted
I still have trouble with mobile responsiveness..
@adeleke5140
Posted
what troubles do you have?