Skip to content
OverviewSolutions
9
Comments
8
Kakeru
@adeleke5140

All comments

  • MsIndy•20
    @MsindySubmitted about 2 years ago

    I have difficulties with working out media queries. I cannot seem to figure it out.Feedback is highly appreciated

    QR code component solution

    2
    Kakeru•265
    @adeleke5140Posted about 2 years ago

    Hi Misindy, great submission. I looked through your codebase and it seemed that the styles for the heading and text did not apply. This is in reference to the font-weight and width properties. Also it doesn't seem like the font-family was applied. You should check them and see why they aren't working.

    What do you need help with in regards to media queries?

    Marked as helpful
    0
  • Kakeru•265
    @adeleke5140Posted over 2 years ago

    Hi Clarence, Your readme is very detailed. Great work on that.

    I checked out your repo and I saw that you pushed your node_modules folder to github. It's always recommended to ignore the node_modules folder.

    To do that for your next project, ensure you add /node_modules in your .gitignore file.

    Marked as helpful
    0
  • Kakeru•265
    @adeleke5140Posted over 2 years ago

    I visited the preview link and an error keeps showing. It says: "I'm Sorry But Something Went Wrong. Code:0"

    What could be wrong? if you feel like sharing, I'd be willing to help out.

    0
  • Iffie Ovie•260
    @ovie009Submitted over 2 years ago

    I just wanted to know if we are allowed top make slight modifications to the design, I included a sort dropdown and scroll to top button because I felt there were necessary, just wanted to be sure if we are allowed to do that?

    JQuery, CSS Display flex, CSS Variables

    2
    Kakeru•265
    @adeleke5140Posted over 2 years ago

    Of course, you are allowed to make as many modifications as you like.

    0
  • Chris•410
    @cbserraSubmitted over 2 years ago
    • Customizing the CSS of react-select components was very tedious
    • Still learning better ways to use @media tags / determining viewport to serve the appropriate CSS (maybe styled-components will be a better avenue than 1:1 CSS file for each Component).
    • Always looking for feedback on best practices! e.g. CSS layout, ContextProvider, React Component design.

    REST Countries API (React/react-select/Dark Theme/Responsive UI)

    1
    Kakeru•265
    @adeleke5140Posted over 2 years ago

    Great project.

    A couple issues I noticed from the live preview are:

    1. The theme text doesn't switch, it stays as dark mode.
    2. the fading that occurs is a bit too slow. I know you were going for a smooth transition but I believe that can be improved.

    You mentioned using React-select, how about trying out the native HTML select form control?

    Marked as helpful
    1
  • Kakeru•265
    @adeleke5140Posted over 2 years ago

    Have you tried looking into the HTML and accessibility issues that was generated??

    They are one way of improving your webapp. And Redux might not really be necessary unless you need that global state. In my attempt, I used prop drilling but moving forward, I'd be employing Context to keep things clean and readable.

    Marked as helpful
    1
  • Sharon•20
    @EnjegheOSubmitted almost 4 years ago

    I would appreciate if I'm given suggestions on better ways to set the background images for the body and how I can use percentages instead of pixels to set the sizes and positions of the background images. Also, general feedback would be appreciated.

    Profile card site using Flexbox

    3
    Kakeru•265
    @adeleke5140Posted almost 4 years ago

    I don't really know how to explain the percentages stuff because all I did was mess around with the values and it kinda worked. why is it stretched out though?

    You can also check my github for the background solution https://github.com/adeleke5140/profile-card-component

    1
  • Kakeru•265
    @adeleke5140Posted about 4 years ago

    what troubles do you have?

    0