@adeleke5140
Posted
Great project.
A couple issues I noticed from the live preview are:
- The theme text doesn't switch, it stays as dark mode.
- the fading that occurs is a bit too slow. I know you were going for a smooth transition but I believe that can be improved.
You mentioned using React-select, how about trying out the native HTML select form control?
Marked as helpful
@cbserra
Posted
@adeleke5140 Thank you for the feedback!
- Is this on the main page listing the countries where the theme text doesn't switch for you? I see it switches for me (macOS, Chrome), but I did create a
* { transition: .5s }css property -- I see it lags a bit, so I should maybe look into targeting elements and transition properties. Also, I wonder if rendering all 200+ countries at once is slowing the UI up, too. I'm going to look into pagination. - Also discussed in bullet point 1 :) .
The native HTML select form control -- I'm using react-select for both the 'Country Search' input as well as the 'Filter Region' -- are you saying just use native <select> for the region filtering? Saying the react-select may be a bit too heavy?
@adeleke5140
Posted
@cbserra Hi Chris, Yes, it's the main page, even after switching to dark mode, the text still says "dark mode" instead of "light mode".
The transition is excellent, but a bit slow.
Regarding react-select, it's a nifty library but sometimes native HTML select elements hooked up with event handlers and callbacks can be sufficient for your needs
@cbserra
Posted
@adeleke5140 ohhhh. That text. I guess it was intentional. I was hoping the solid moon would act as the toggle for “true”, but maybe I should change the text as well.
