All comments

• 

  Dolly-Pee• 140

  @Dolly-Pee

  Submitted about 1 year ago

  Please go through my code and highlight areas i can improve on..

  kinda having problem with using 100vh height on pages that takes more than the view-port page without scrolling

  

  NFT preview card with flexBox

  1

  30

  

  Pablo• 550

  @ackDeckard

  Posted about 1 year ago

  Almost there Dolly-Pee 👏

  Two suggestions:

  a) Use grid or flex to align items at the center of the screen. For example with grid you'll need to add this to your <main>

  display: grid; justify-items: center; align-items: center;

  b) Move your divs to their own <section>.

  <main style="display: grid;justify-items: center;align-items: center;"> <section>

  <div class="card container"> .... </div>

  <div class="attribution"> .... </div>

  </section>

  </main>

  With these suggestions you'll have everything in the center.

  Marked as helpful

  0
• 

  P

  Koya• 310

  @koyaboy

  Submitted over 1 year ago

  

  NFT preview card component using flexbox

  2

  40

  

  Pablo• 550

  @ackDeckard

  Posted over 1 year ago

  Hello Koya,

  Congratulations on successfully completing another challenge!

  I would like to suggest that you add two things:

  • white-space: nowrap; to your price-days-left class. This will prevent the line from wrapping.
  • border-radius: 8px; to your image to add a rounded borders.

  Keep going 👏

  Marked as helpful

  0

  This comment has received 1 replyShow