Skip to content
OverviewSolutions
29
Comments
2
Pablo
@ackDeckard

All comments

  • Dolly-Peeā€¢140
    @Dolly-PeeSubmitted over 1 year ago

    Please go through my code and highlight areas i can improve on..

    kinda having problem with using 100vh height on pages that takes more than the view-port page without scrolling

    NFT preview card with flexBox

    1
    Pabloā€¢550
    @ackDeckardPosted over 1 year ago

    Almost there Dolly-Pee šŸ‘

    Two suggestions:

    a) Use grid or flex to align items at the center of the screen. For example with grid you'll need to add this to your <main>

    display: grid; justify-items: center; align-items: center;

    b) Move your divs to their own <section>.

    <main style="display: grid;justify-items: center;align-items: center;"> <section>

    <div class="card container"> .... </div>

    <div class="attribution"> .... </div>

    </section>

    </main>

    With these suggestions you'll have everything in the center.

    Marked as helpful
    0
  • Pabloā€¢550
    @ackDeckardPosted over 1 year ago

    Hello Koya,

    Congratulations on successfully completing another challenge!

    I would like to suggest that you add two things:

    • white-space: nowrap; to your price-days-left class. This will prevent the line from wrapping.
    • border-radius: 8px; to your image to add a rounded borders.

    Keep going šŸ‘

    Marked as helpful
    0