NFT preview card component using flexbox

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="body"> with the main tag and <h3> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .card-container on the page using flexbox, replace the height in the body with min-height: 100vh.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Pablo•550

  @ackDeckardPosted over 1 year ago

  Hello Koya,

  Congratulations on successfully completing another challenge!

  I would like to suggest that you add two things:

  • white-space: nowrap; to your price-days-left class. This will prevent the line from wrapping.
  • border-radius: 8px; to your image to add a rounded borders.

  Keep going 👏

  Marked as helpful

  0

  ---

  

  P

  Koya•310

  @koyaboyPosted over 1 year ago

  @ackDeckard Never knew of white-space: no wrap till now, thanks pablo

  0