ShivamRajput57• 150
@ShivamRajput57
Submitted
abigbroomstick
@abigbroomstick
All comments
- abigbroomstick• 70
@abigbroomstick
Posted
You should fix the spacing and margins between elements and rewrite the table below. Tips: you could use the Grid layout for the table!
0 - Ryan Hardy• 110
@ryyHardy
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of how close I got to the design guide and the process I used to get there. I felt like I was a lot quicker at setting up the HTML and that allowed me to focus on the CSS as early as possible. I think I am starting to get the hang of these small "card" challenges.
What challenges did you encounter, and how did you overcome them?
I was debating whether to use a list or plain flexbox for the social links. I found that the flexbox way was easier to style this time around. Towards the end I noticed that I didn't have as much space at the bottom of the card as the images, so I had to increase the height of the card to get it to match. I had to use a lot of random values for spacing the text properly like 0.3em or 0.7rem. I don't want to get in the habit of hacking it together with random values, if I can help it.
What specific areas of your project would you like help with?
I am starting to notice how useful CSS variables can be. I know it doesn't apply as much in smaller challenges, but I want to learn how CSS variables are named/organized in larger projects to make things more consistent. Like usual, I could always use feedback on how the HTML as structured and if I did anything messy or unnecessary in the CSS.
abigbroomstick• 70@abigbroomstick
Posted
You have made good use of flexbox. I personally would put the text in an <article> element because <figcaption> is used more for writing/describing about a photo. Good work!
1 - jpcardozx• 100
@jpcardozx
Submitted
abigbroomstick• 70@abigbroomstick
Posted
You should center it by using flexbox or grid layout! Nice job anyways! You are very close!
0 - markbien• 20
@markbien
Submitted
What are you most proud of, and what would you do differently next time?
I'm happy that I was able to make the page a bit responsive to cater desktop and mobile view.
What challenges did you encounter, and how did you overcome them?
I had a bit of trouble with the footer making it appear correctly in mobile view. It turns out I didn't have to add too much CSS code to align it correctly.
What specific areas of your project would you like help with?
I have no questions at the moment. I may just need to practice a lot and apply the things I learned about HTML and CSS.
abigbroomstick• 70@abigbroomstick
Posted
Nice work!
Marked as helpful
0
