Any feedback welcomed π
Abhijit Barman
@abhijitbcobAll comments
- @MainlyColorsSubmitted about 3 years ago@abhijitbcobPosted about 3 years ago
I really liked your css code. My one tip for making the toggle switch scalable:
- assign the width of circle slider to a variable
- then using multiplicand of the variable define the width of the switch
- transform the slider using the multiplicand of the variable(use calc())
- then just change the variable value and everything will change
Marked as helpful1 - @hemanuelaSubmitted over 3 years ago
Feedbacks are welcome :D
Tks in advance
@abhijitbcobPosted over 3 years agoHi Hemanuela, In desktop view everything looks nice! But in mobile view I've noticed that you've set a width to body, and this is creating problem with responsiveness and under 375px width layout is not appearing properly.
my tips:
- set responsive width (max-width property) to elements
- don't always use fixed padding(huge padding) instead set max-width to content and center inside container
Marked as helpful0 - @costelloewardSubmitted over 3 years ago
Hi everyone,
This is a work in progress, any feedback much appreciated. I'm unsure about the positioning of the boxes, especially the testimonials. Is there a better way than margins?
@abhijitbcobPosted over 3 years agoHi, Yeah, there is a better way than margin.
- Give the testimonial cards container a height(bigger than each card), make it flex or grid container
- set the first card(align-self: start), second card(align-self: center) and third card(align-self: end)
Marked as helpful0 - @JoyShahebSubmitted over 3 years ago
If I Missed any web dev best practices, let me know. Suggestions & Criticisms are highly appreciated π
@abhijitbcobPosted over 3 years agoπ
Hey Joy! how are you brother? I am one of your FB followers.
1 - @karbowskamSubmitted over 3 years ago
I'm on fire! (I think? :D) But seriously - I hope the effect is quite good :)
@abhijitbcobPosted over 3 years agolooking very nice! Here is my some tips:
- to center any element in body just only use
display: grid; place-items: center
; - instead of writing row height, use padding inside every card component.
- in mobile view write
grid-template-columns: minmax(0, 325px)
so that the card be responsive.
Marked as helpful0 - to center any element in body just only use
- @manavkhadka0Submitted over 3 years ago
I will be glad for you to like and comment on my problems as well.
@abhijitbcobPosted over 3 years agouse photoshop or similar kind of tool to measure every element of the design(image file) so that you can give your site close look to the provided design and otherwise everything is fine.
0 - @emmy-htmlSubmitted over 3 years ago
I would love some feedback on how you all were able to achieve the fully rounded border-bottom on the 'Learn More' text! I was only able to get it to round itself out on the bottom half. As always I'm open to any other feedback as well.
@abhijitbcobPosted over 3 years agothe little white triangle in the mobile menu that was nice!
1 - @luwa-starSubmitted almost 4 years ago
This is my first time using SCSS in a project. I would appreciate any times on the best practices for SCSS. Thank you.
@abhijitbcobPosted almost 4 years agoGood! I think you can give this design better improvement, if you correct some alignments and sizes. Like, put each section's content in a same size container, make this container responsive for all devices, justify it center. Then, make the mobile menu links a little smaller with no scrolling.
0