Feedback is welcome
Abdelilah
@abdeldevprojectsAll comments
- @abdeldevprojectsSubmitted almost 3 years ago@abdeldevprojectsPosted almost 3 years ago
thank you Tymur for taking time to read my code that really made me happy im going to fix the spacing issue thank you for the tip <3
0 - @Rohitgour03Submitted almost 3 years ago
Here is my solution to this challenge. 🔥 Please provide your feedback for improvement. 🙏 Thanks in advance.
@abdeldevprojectsPosted almost 3 years agoeverything works fine except i didn't understand why you used email instead of input variable in
line 8 : if (email.value.trim() == "") line 12 : else if (!validateEmail(email.value)
i think it should be
line 8 : if (input.value.trim() == "") line 12 : else if (!validateEmail(input.value)
i might be wrong because i am not an expert , still learning
thank you and happy coding <3
Marked as helpful1 - @abdeldevprojectsSubmitted almost 3 years ago
i did it responsive first it looks cool but in Desktop preview the progressive spacing didn't work for me i will keep trying to make it work and upload another version of the code, if someone know how can i fix it please tell me , Ty <3.
@abdeldevprojectsPosted almost 3 years agoi did a height : 100% on each testimonial card and a margin-top to do the progressive spacing same thing for the rated stars items, the layout is not yet perfect but im happy with it <3
0 - @abdeldevprojectsSubmitted almost 3 years ago
happy coding everyone <3, feedback is welcome.
- @abdeldevprojectsSubmitted almost 3 years ago
happy coding everyone <3, feedback is welcome.
@abdeldevprojectsPosted almost 3 years agoThank you so much for taking time to read my code and writing this amaizing feedback , im going to work today on the things you mentioned , thank you again <3
0 - @sharathkumar106Submitted about 3 years ago@abdeldevprojectsPosted about 3 years ago
the github link is not working i think you removed the repo , send it to me when you will upload it back
0