Responsive first using CSS grid and Flexbox

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi Abdelilah,

  This is a great solution, really well done!

  The responsiveness is on point leveraging grid and good use of semantic html.

  I'd recommend changing one of those <h2>s to a <h1> to clear your accessibility report. Here is some interesting info on heading hiearchy.

  All the best!

  Marked as helpful

  1

  ---

  

  Abdelilah•180

  @abdeldevprojectsPosted almost 3 years ago

  @darryncodes Hi Darry thank you for your feedback im going to correct the accessibility problem after i finish a project , thank you again ! :)

  0
• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @abdeldevprojects ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide. On wider screens, spacing between cards go wider. I think setting max-width to .cards element can solve this issue.

  If it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  1
• 

  Abdelilah•180

  @abdeldevprojectsPosted almost 3 years ago

  thank you Tymur for taking time to read my code that really made me happy im going to fix the spacing issue thank you for the tip <3

  0