Skip to content
OverviewSolutions
7
Comments
6
AYUSH RANJAN
@aayusranjan

All comments

  • AYUSH RANJAN•170
    @aayusranjanPosted over 2 years ago

    Hey @Geo0510! I went through your solution, it's good.

    • I would suggest you try to avoid use div, for example you use <footer> instead of `<div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank" >Frontend Mentor</a >. Coded by <a href="#">Esteban Salas</a>.

      </div>`

    • you can look to at my solution as a reference

    Marked as helpful
    0
  • AYUSH RANJAN•170
    @aayusranjanPosted almost 3 years ago

    Good work, Santiago!

    • use main instead of <div id="root">
    0
  • Erica•30
    @YoThatsCrazySubmitted almost 3 years ago

    This is my very first time coding and I got stuck for a bit but I stuck with it. Github is throwing me through a loop but I'm having trouble with Github pages and my images showing on my live URL. Let me know what I can improve on even though this is basic, and help on the Github pages as well.

    Here's my QR code challenge solution.

    3
    AYUSH RANJAN•170
    @aayusranjanPosted almost 3 years ago

    the reason is not showing your image is:

    • you used your local path, instead of <img class="card-img" src="C:\Users\erica\OneDrive\Desktop\QR Code practice\images\image-qr-code.png" alt=""> use <img class="card-img" src="images/image-qr-code.png" alt="qr code image"> .
    Marked as helpful
    0
  • AYUSH RANJAN•170
    @aayusranjanPosted almost 3 years ago

    Great work Emanuel !

    • There will you can add hover on .item__button and .checkout__pay-btn it will be more better.
    • You don't need to creat button tag, it's like so good to go with a tag in .item__button and .checkout__cancel-btn

    you can check out my solution

    Marked as helpful
    1
  • AYUSH RANJAN•170
    @aayusranjanPosted almost 3 years ago

    That's really great work. I would like to give some feedback

    • Ig no need of section and id selectors (most case avoid to use id selectors ).
    • add root in CSS ( it's would really helpful, and add there all color given in style guide)
    • change paragraph color. ( it might be better if you use class in h and p tag )

    you can go through my solution : https://www.frontendmentor.io/solutions/qr-code-component-aAq0MFl4r

    Marked as helpful
    2
  • AYUSH RANJAN•170
    @aayusranjanPosted almost 3 years ago

    add img tag before <h2 class="heading">Sedans</h2>

    0