QR Code component

Community feedback

• 

  AYUSH RANJAN•170

  @aayusranjanPosted almost 3 years ago

  That's really great work. I would like to give some feedback

  • Ig no need of section and id selectors (most case avoid to use id selectors ).
  • add root in CSS ( it's would really helpful, and add there all color given in style guide)
  • change paragraph color. ( it might be better if you use class in h and p tag )

  you can go through my solution : https://www.frontendmentor.io/solutions/qr-code-component-aAq0MFl4r

  Marked as helpful

  2

  ---

  

  Fabiana Menezes•30

  @fabifeliciaPosted almost 3 years ago

  @aayusranjan thanks for the suggestions

  1
• 

  sb101-beep•60

  @sb101-beepPosted almost 3 years ago

  Looks great, I would probably try and make the design a little bigger to match up more with the front end mentor designs :-)

  Marked as helpful

  1

  ---

  

  Fabiana Menezes•30

  @fabifeliciaPosted almost 3 years ago

  @sb101-beep thanks for the observation. I really didn't realize how different it was in size

  0