@skyleranglhSubmitted 3 months ago
a-yemisi
@a-yemisiAll comments
- @J-JawadSubmitted 3 months ago@a-yemisiPosted 3 months ago
Your site showed up the android format on my laptop screen, you might want to reduce the screen width where the media break occurs. Asides from that, no issues. You did well, well done.
0 - @Rapbit27Submitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
Changing the pictures when the view changed was quite difficult. The second thing was fitting the picture to full height of the card in desktop view.
What specific areas of your project would you like help with?I would like help on the above mentioned problem. Changing the pictures when in different views and also with sizing them accordingly. Thanks in advance!!
@a-yemisiPosted 3 months agoFor the images, there were two images sent for the challenge, you could use media query. For the smaller screen size, ask it to use the mobile image, for larger, use desktop. You can use CSS to make to add an image to an HTML page, look up how that is done.
Asides from that well done.
1 - @abdelkarim-el-manssouriSubmitted 3 months ago@a-yemisiPosted 3 months ago
The HTML is fine, the CSS is there. I can see that you used the media query, but the website behaves the same way and has the same appearance for both smaller and larger screens. This should not be so from the design given.
Asides from that, it was fine.
0 - @Renzo2O99Submitted 4 months ago@a-yemisiPosted 4 months ago
Does the solution include semantic HTML? I do not necessarily see semantic HTML, but the solution is not complicated, so it's fine if there is no semantic HTML. . . Is it accessible, and what improvements could be made? The solution is accessible, the solution is close enough to the design but could be better. . . Does the layout look good on a range of screen sizes? The layout looks good on a range of screen sizes. . . Is the code well-structured, readable, and reusable? I am not sure about the structure of your code, your html is readable, but your CSS is a lot. It will be easier to study if it was simpler, I did not understand the need for 3 CSS files. . . Does the solution differ considerably from the design? The solution differed from the design, but generally it was fine.
In conclusion, your design is fine, my major concern was the structure of your CSS code, and that it differs a bit from the original design. Good job!
0 - @simplyObareSubmitted 4 months ago@a-yemisiPosted 4 months ago
Does the solution include semantic HTML? Fine enough Is it accessible, and what improvements could be made? It is Does the layout look good on a range of screen sizes? It should Is the code well-structured, readable, and reusable? Yes Does the solution differ considerably from the design? Yes, the card is not centralized on the page
Altogether, it is well done, just the issue of the position of the card.
0 - @Akinloluwa-AdedijoSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Proud of figuting out how to center a div and the text as well.
What challenges did you encounter, and how did you overcome them?Centering the div
@a-yemisiPosted 4 months agoUnfortunately, cannot access your code The layout is okay There seems to be some issues with rendering the image Generally, it's fine
0
