Skip to content
OverviewSolutions
18
Comments
5
Yohan Reyes
@Yohanr19

All comments

  • Yohan Reyes•300
    @Yohanr19Posted over 3 years ago

    The background patter was given as a resource image, you have to use the background properties to make it fit, anyway those snakes actually look very cool, so i don't mind them. Good job! Happy Codding.

    0
  • Jordan Cellier-Auffret•10
    @JcellierSubmitted over 3 years ago

    Any feedback will be greatly appreciated. Also, in the desktop version, I can't change the height of my page, which results in having a scroll down option, only to see black background. If you know how to solve this issue, that would be awesome. Cheers!

    Stats challenge using Sass and Bem methods

    1
    Yohan Reyes•300
    @Yohanr19Posted over 3 years ago

    Hello Jordan, good job!!! The reason you having trouble with the scroll down is because of you giving manual heights to your components, is not advised to use to height property to set a fixed height, instead yo should limit yourself to using either the min-height or the max-height property to control your components, also the padding top/bottom should be used instead if you 100% need your component to have a fixed height.

    Try to mess around removing all the fixed heights and then try to make it look good. Happy coding !

    Marked as helpful
    0
  • Yohan Reyes•300
    @Yohanr19Posted over 3 years ago

    Hey Siddhesh Kamble , your code looks great. I think now you should try to step up your game and try to add a transition to your bar.

    A few tips to do it: You need to use a different approach to handle the visibility of the bar, instead of relying on changing the display to ''none'', yo should try to hide with either opacity (setting it to 0 and then changing it to 1, is a easy way to make a fading effect). You can also handle it with the visibility property and by putting it to hidden and making the width and height 0, you can then change those property to the normal values and that will give the effect of the object appearing from the side/top. Which is also pretty cool. Try to mess around with those concepts and hit me up if you get stuck. Happy Coding!!!!

    Marked as helpful
    0
  • Yohan Reyes•300
    @Yohanr19Posted over 3 years ago

    Hey Palash Meena , great job. Here is some feedback i can give you after checking your CSS file.

    1- Yo should use common classes more effectively, what do i mean? at one point in your styles you did something like this:

    card-colton{margin: 10px auto;} card-irene{margin: 10px auto;} card-anne{margin:10px auto;}

    this is quite ineffective, and you can cut a lot of work if you added a common class into those elements, remember class are separated with spaces so if you declared ''card'' as a separate class you could affect all the elements with only 1 line of code.

    2- Yo always need to check for typos, specially when they are present on your classes, i see you used the ''reviwe'' class a lot, which i suppose is a typo of ''review'', your app will still work with a typo, but once you come back to your code it will mess whit you!!!

    0
  • Al Rahat•120
    @AlRahatSubmitted over 3 years ago

    I can't figure out the way to put those background image . I tried to add background image in css but it didn't work. Besides I have made my code a lot more complicated and made some mistakes as well. So I would love to have some help ...

    Blogr-publishing-platform

    1
    Yohan Reyes•300
    @Yohanr19Posted over 3 years ago

    Hey! Your design looks very similar to the original, congratulations! But I tried to take a look to the implementation and give some advice, but it seems that you have linked the incorrect Github url, try fixing it so other people can see your implementation!

    1