Design comparison
Solution retrospective
Any code/visual feedback appreciated :)
Community feedback
- @Yohanr19Posted over 3 years ago
Hey Palash Meena , great job. Here is some feedback i can give you after checking your CSS file.
1- Yo should use common classes more effectively, what do i mean? at one point in your styles you did something like this:
card-colton{margin: 10px auto;} card-irene{margin: 10px auto;} card-anne{margin:10px auto;}
this is quite ineffective, and you can cut a lot of work if you added a common class into those elements, remember class are separated with spaces so if you declared ''card'' as a separate class you could affect all the elements with only 1 line of code.
2- Yo always need to check for typos, specially when they are present on your classes, i see you used the ''reviwe'' class a lot, which i suppose is a typo of ''review'', your app will still work with a typo, but once you come back to your code it will mess whit you!!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord