All solutions

1- is there any better way to do this? 2- is any part is un appropriate in my code? 3- i want review and response. 4- in any part i can do better ?