Skip to content
OverviewSolutions
15
Comments
3
Watership 🌊
@Watership6

All comments

  • Watership 🌊•320
    @Watership6Posted over 1 year ago

    Hi @EmileeEversole🧑‍💻,

    I really like the solution that you have come up with👌, however I have a few critiques that I think could make your code quality and overall website better and more accessible✅:

    1. Add aria labels to ensure that screen readers can also access the form.🪄
    2. Add validation to the form as the user is inputting into it as well.⭐
    3. Store your font faces and access them locally instead of importing them, allowing the typefaces in the UI to look better.🛩️

    Overall, your solution is really good and I can't wait to see more of your projects/solutions as you progress on your coding journey.✌️

    Keep coding, Watership🌊😁

    0
  • Watership 🌊•320
    @Watership6Posted over 1 year ago

    Hey @dhinesh20022806🧑‍💻, Good job on this solution. ✅ Here are a few edits I think you could implement into your code to improve it🪄:

    1. Add aria labels to your html to make it more accessible and improve your code quality.
    2. For your regex, I would suggest you include other email types such as outlook, making your validation more effective. 🤖
    3. Take the <br/> tags that are no needed out and consider using css styling to break element apart instead such as using flexbox to put the button element below the input element instead of the <br/> tag. ⭐

    Overall, your solution is really good, and I can't wait to see more of your work and improvement as you finish and code up more solutions! 😁

    Keep Coding, Watership💧🌊

    Marked as helpful
    0
  • Welder Victor•80
    @weldersalvadorSubmitted over 1 year ago

    My first project utilizing JavasCript. If you have any suggestions, please comment ^^

    Pricing Component

    2
    Watership 🌊•320
    @Watership6Posted over 1 year ago

    Nice job😁,

    I really liked your solution especially for being the first one you have done with JS. I have a few critiques that I would like to suggest you add to make your code better✅:

    1. Add aria labels , not only helping your code quality better but also make your website more accessible.
    2. Make your font families be added in locally to your project file as it make it look better.
    3. A very small change but make the circle in your toggle a bit smaller to make your website look a bit better. ⭐

    Overall, I really liked your solution and can't wait for your next solution. Thank you for sharing you solution with us. 🧑‍💻

    Sincerely, Watership🌊💧🛩️

    Marked as helpful
    2