newsletter-signup-form-with-success-message-
Design comparison
Solution retrospective
hey, if you're see this, I'm in noob level.So what the one thing that make me better in the web development.
Community feedback
- @Watership6Posted over 1 year ago
Hey @dhinesh20022806π§βπ», Good job on this solution. β Here are a few edits I think you could implement into your code to improve itπͺ:
- Add aria labels to your html to make it more accessible and improve your code quality.
- For your regex, I would suggest you include other email types such as outlook, making your validation more effective. π€
- Take the <br/> tags that are no needed out and consider using css styling to break element apart instead such as using flexbox to put the button element below the input element instead of the <br/> tag. β
Overall, your solution is really good, and I can't wait to see more of your work and improvement as you finish and code up more solutions! π
Keep Coding, Watershipπ§π
Marked as helpful0@dhinesh20022806Posted over 1 year agoHey @Hyoaku π
Thanks a bunch for your valuable feedback and suggestions! π I really appreciate your insights and the time you took to review my code. I'll definitely work on implementing the changes you've recommended to enhance the accessibility, email validation, and overall code structure. Adding aria labels, expanding the email validation regex, and using CSS styling with flexbox are fantastic ideas that will undoubtedly improve the quality and functionality of the solution.
Your encouragement means a lot to me, and I'm super excited to continue refining my skills and producing even better solutions in the future. Thanks once again for your support and guidance! π Keep Coding and making waves, Watership! π§π
Cheers, Dhinesh π§βπ»
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord