YOadYo06• 140
@YOadYo06
Submitted
feedbacks please
Muhammad Wali
@Wali1209
All comments
- Muhammad Wali• 210
@Wali1209
Posted
Hey! @YOadYo06
WellDone! I liked your background :)
As you ask for feedback this is what I think I don't like fixed height and width cus when you decrease the screen size your QR card(child element) gets smaller and smaller which may be not good in this particular case. So, you can use max-width and min-height for the main element
main{ max-width: 90dvw; min-height:72dvh: }
and under 420px screen size,
the card looks really weird that's what I think plz correct me If I'm wrong! And that's it keep up the good work :)
Regards
M Wali
Marked as helpful
1 - Muriel M.• 420
@MurielM87
Submitted
Muhammad Wali• 210@Wali1209
Posted
Hey! @MurielM87 I have read your code. Well done! But few think you can consider:
- Use <input type="number" > that is specifically designed for accepting numerical input from the user. It also supports additional attributes like step and min/max range
- Using rem instead of px for specifying lengths in CSS can be a good practice, especially for creating responsive and scalable designs.
- For Example
input {
width: 9rem; font-size: 2rem; padding: 1rem;
}
.output h1 {
font-size: 5rem;
}
@media screen and (max-width: 600px) {
.card {
width: 22.5rem;
}
.container {
padding: 1.5rem;
}
}
- You can get a given month's total number of days using the getDate() Method
- Your form is not validated perfectly especially not the Day Input box
I also submit my Age-calculator challenge you can see my solution If you want and plz let me know how you rate my code.
Regards M Wali
0
