Design comparison
Solution retrospective
feedbacks please
Community feedback
- @Wali1209Posted over 1 year ago
Hey! @YOadYo06
WellDone! I liked your background :)
As you ask for feedback this is what I think I don't like fixed height and width cus when you decrease the screen size your QR card(child element) gets smaller and smaller which may be not good in this particular case. So, you can use max-width and min-height for the main element
main{ max-width: 90dvw; min-height:72dvh: }
and under 420px screen size,
the card looks really weird that's what I think plz correct me If I'm wrong! And that's it keep up the good work :)
Regards
M Wali
Marked as helpful1 - @itushPosted over 1 year ago
Congratulations on completing the challenge! ๐
Welcome to the platform! ๐ We're thrilled to have you here and excited to see your progress ๐ชas you continue your front-end development journey.
Nice attempt :)
- While I totally understand the effort it takes to write 3900+ lines of vanilla CSS ๐คฏI guess it was not necessary for this project.
In my projects:
- I always start with mobile-first workflow.
- I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
<body> <main> All content </main> </body>-
I Use relative units as much as possible and avoid absolute units whenever possible.
-
If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project(which you did). Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gapโ ๏ธ please first solidify HTML, CSS, JS fundamentals and then move on to any framework or library.
-
I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! ๐ To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:
๐๐ 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.
๐๐ 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.
I hope you find these resources helpful in your coding adventures! ๐ค
I'm eagerly looking forward to seeing the amazing projects you'll create in the future! ๐๐ป
Keep up the fantastic work and happy hacking! ๐ชโจ
Marked as helpful1@itushPosted over 1 year ago@YOadYo06
You are most welcome!
Always happy to help :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord