Skip to content
OverviewSolutions
16
Comments
7
WaelBenseghir
@WaelBenseghir

All comments

  • WaelBenseghir•160
    @WaelBenseghirPosted 3 months ago

    did you make it using the figma file ? it looks like it's px perfect

    1
  • WaelBenseghir•160
    @WaelBenseghirPosted 3 months ago

    How did you make the design this close? did you use the figma design ?

    0
  • Obare•320
    @simplyObareSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    Am proud I completed the challenge

    What challenges did you encounter, and how did you overcome them?

    I had an issue with the product image, I couldn't make it responsive. Initially I had it as an image in the html, but then I changed it to be a background-image in CSS. Which made it easier to make it responsive.

    What specific areas of your project would you like help with?

    No specific areas in particular, an feedback is welcomed

    Product preview card component

    1
    WaelBenseghir•160
    @WaelBenseghirPosted 4 months ago

    Why did you use Grid and not Flexbox ? also why did not use max-width: 100% for the container.

    that's what i did and I'm not saying you did it wrong, just out of curiosity.

    0
  • WaelBenseghir•160
    @WaelBenseghirPosted 4 months ago

    Font size and weight are a bit too much

    0
  • Sunil•180
    @SunilParbhooSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I am proud to have completed this challenge as accurately as I could without the use of Figma files, and I am proud of the animation hover effects I created using just HTML and CSS. I am continuing to try to improve my use of Semantic HTML and site responsiveness.

    What challenges did you encounter, and how did you overcome them?

    The challenge posed was trying to approximate unit lengths for the elements (margins/padding etc.) without the use of a Figma design. I attempted to approximate these details as accurately as I could using Macs Preview application with the provided design jpgs. I was able to click and drag between items in the image and get a number in pixels to then use in my CSS code.

    What specific areas of your project would you like help with?

    I am always open to constructive feedback, especially if there are any potential areas that are generally considered best practices that I should be incorporating into my code, or if there are design patterns that I could better be utilizing to improve my code.

    Social Links Profile

    2
    WaelBenseghir•160
    @WaelBenseghirPosted 4 months ago

    I see no difference

    1
  • WaelBenseghir•160
    @WaelBenseghirPosted 4 months ago

    Good layout

    0
  • WaelBenseghir•160
    @WaelBenseghirPosted 4 months ago

    Good design

    0