Skip to content
OverviewSolutions
7
Comments
7
P
Untest57
@Untest57

All comments

  • Untest57•80
    @Untest57Posted about 1 month ago

    Hello @Mario-jesus. I applaud your challenge.

    1. I was surprised that the challenger design and challenge results were so similar.
    2. I was also surprised by the card part that implemented a combination of scss mixin and css variable.

    I would like to share some opinions.

    • When I looked at the repository, the node_modules folder was also uploaded.

      I don't know if this was intentional, but it is usually excluded from node projects.

      Please refer to github.com/github/gitignore.

    1
  • Untest57•80
    @Untest57Posted about 2 months ago

    Hello Ivan. I applaud your challenge.

    The fact that it responds appropriately to the screen is very impressive.

    I would like to share some opinions.

    • The spacing of the header text seems a little different from the given design.
    • I think the header text size is a little different in the desktop screen size.
    0
  • Carlos Marte•160
    @carlosmarte23Submitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    I've successfully styled my project using SASS/SCSS, though it was a challenging first experience. After extensive research, I believe I did a decent job. I plan to continue using it in future projects to become more proficient.

    What challenges did you encounter, and how did you overcome them?

    Since it was my first time using SASS, getting used to the syntax and multiple files, as well as the nesting it was challenging to say the least. I think i did a good job in the end after a lot of research on it about the common practices.

    What specific areas of your project would you like help with?

    Please focus on the SASS/SCSS, if possible, what i did wrong or what can i improve on for the next time. thank you so much for your feedback.

    Product Preview Card Component

    2
    Untest57•80
    @Untest57Posted about 2 months ago

    Hello Carlos Marte. I applaud your challenge. I was impressed by the increase in responsiveness on mobile.

    I would like to share some opinions.

    • There is something different from the design provided in the challenge.

      The size ratio of images and text does not match in Desktop.

    1
  • Untest57•80
    @Untest57Posted 2 months ago

    Hello KTshibangu I applaud your challenge

    I would like to share some opinions

    • There is something different from the design provided in the challenge.
      • It appears to be intentional as each heading size is different and there is no separate reset.
      • The text and background colors of various parts are different.
    • I think it would be better to write the <div class="nutrition-list"> part as <table>.
    0
  • Untest57•80
    @Untest57Posted 2 months ago

    Hi, Igor Chaves I applaud your challenge. I would like to give you a few opinions.

    1. I think the design and height are a bit different.
    2. I don't know if this was your intention, but only the desktop version is implemented.
    3. There is no button response.
    4. Following the above, elements that appear as buttons or links are written as <p>. I think it would be better to write it as <a>.
    1
  • Untest57•80
    @Untest57Posted 2 months ago

    The implementation of text reduction without media queries was very impressive.

    There is little possibility of reuse, but I think it would be better if you wrap the card content in <article> instead of putting it directly in <main>.

    1
  • Untest57•80
    @Untest57Posted 2 months ago

    I think the solution is different from the size of the design provided by Challenge.

    0