Skip to content
OverviewSolutions
4
Comments
3
Eli
@Tyubit

All comments

  • Eli•120
    @TyubitPosted over 1 year ago

    Good job. If you'd like to improve your work, here some tips and problems: 1:I would make class options as form (but it's just option) 2: divs in options would be good to add width: 100%; and if it's affect others div add another class name 3: calculation is wrong "bill: 100, tip: 50%, people: 2 = 62.5" should be 75

    I hope it will help you

    1
  • Eli•120
    @TyubitPosted over 1 year ago

    Awesome job! Looks exactly as design, animation, inputs works good. I found small CSS problem just in case if u want to improve the project. Reset button on preview website light green with black text. I'm using Chrome, btw.

    1
  • Eli•120
    @TyubitPosted about 2 years ago

    Hello, you made good job. I found some places in your code to improve. Here is some:

    1. <div class="code-numbers"> better remove all div inside and make as one string.
    2. to limit and make it only numbers in card number good to use regex on input field
    3. use eventlistener to update information on card in real time. I hope it will help you to improve your code! :)
    Marked as helpful
    1