@mouhibeddine
Submitted
Hello it's been a while since my last upload
here is my solution to this challenge, it's a bit old because i forgot to submit it.
any feedbacks are welcomed !!
TRES
@Tre3s-byte
All comments
- TRES• 90
@Tre3s-byte
Posted
1.It looks pretty neat! There's only one specific point I believe you would like to polish:
- It seems like you've added the path to the icons but forgot to include the actual icon assets in your repository. Make sure to double-check and ensure that all the necessary assets, including icons and images, are properly included in the project repository.
2.There is also a good idea to move the attribution styles to styles.css.
- Keeping all the styles in a central stylesheet helps with organization and maintainability. Make sure to move the relevant styles related to attributions to styles.css and update the HTML accordingly.
3.It's always good to remember some tips for performance.
- Using @import to load fonts can cause a delay in rendering the page, which may affect performance. Instead, it's recommended to use the <link> tag in the HTML to load fonts, as it allows for parallel downloading and better performance.
3.An important asset for a front-end developer is responsiveness.
- Your code on the laptop seems fine, but it doesn't work on mobile. Ensuring that your website is responsive and works well on different devices, including mobile, is crucial. Make sure to review your CSS media queries and layout rules to ensure proper responsiveness. Test your website on various devices or use browser developer tools to simulate different screen sizes and orientations to identify and fix any issues related to responsiveness.
Marked as helpful
0 - nina1234567896• 280
@nina1234567896
Submitted
Any kind of feedback will be appreciated =)
TRES• 90@Tre3s-byte
Posted
Hi Nina,
Overall, it is greatly done. I only have a few specific recommendations:
- It's a good practice to add a "description" meta tag to improve visibility in search engines (SEO).
- Consider moving the styles related to legal information to "styles.css" for better organization.
- Reusing classes is beneficial to minimize code and improve clarity, especially in large projects when collaborating with coworkers. You may want to explore naming methodologies like BEM (Block Element Modifier) to enhance readability.
=) I hope you find this useful!
Marked as helpful
1
