Skip to content
OverviewSolutions
6
Comments
6
TheRoboRobin
@TheRoboRobin

All comments

  • TheRoboRobin•120
    @TheRoboRobinPosted 4 days ago

    Looks great! I like the way you are thinking when it comes using the mixins for your breakpoints.

    But I think that your responsive design is a little lacking. The site starts to break between 1440px and 900px. It's off center and none of the elements adjust to the space available. While the challenge does just pertain to the 1440px and 375px, It's good to think about the breakpoints between that.

    Otherwise, I think you could fix the curve in your top border by just lowering its size by 1px.

    Marked as helpful
    1
  • TheRoboRobin•120
    @TheRoboRobinPosted 7 days ago

    Looks great! Code is well organized. You might add a little more spacing to your media query for your larger design. It feels really tight towards the top.

    Marked as helpful
    1
  • TheRoboRobin•120
    @TheRoboRobinPosted 11 days ago

    Woah! I love the main page that you've created. Very clean and fits within the design feel for each of the projects. If I had anything to say about the challenge itself, it would be that you should maybe adjust the line height a bit. Bodies of text are too squished together. Otherwise, great job!

    1
  • TheRoboRobin•120
    @TheRoboRobinPosted 14 days ago

    I like the way that you handled the responsiveness with the width. But at some point the content feels maybe a bit too big for the space. Maybe add some queries addressing font-size and spacing would help? Great job though!

    Marked as helpful
    1
  • TheRoboRobin•120
    @TheRoboRobinPosted 19 days ago

    It looks great! I would maybe make the text a bit bigger on the original. I would say that it might be a bit small.

    I also think that the way you handled making your image responsive is interesting!

    Otherwise, I think your code is well-structured. Keep up the good work!

    0
  • TheRoboRobin•120
    @TheRoboRobinPosted 19 days ago

    The heading is a bit too crowded and maybe needs a little less padding or a smaller font size. There is also a bunch of extra margin on the bottom that you might want to remove. I kind of like the switched up colors but I'd say the text color should be adjusted to this. Lighter on the darker background and placing one of the darker colors on the body instead of the pure black. Makes the text seem out of place.

    0