Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • mofada• 310

    @mofada

    Submitted

    What challenges did you encounter, and how did you overcome them?

    I learned how to use box-shadow in tailwindcss.

    What specific areas of your project would you like help with?

    1. question 1 Which font did I use?

    I found some fonts in assets/fonts folder. But I don't known which is best.

    2. question 2 Is there a problem with the semantics of HTML?

    I think I need to optimize the semantics, please help me

    TheAashay• 210

    @TheAashay

    Posted

    For HTML semantics, wrap the main content of the HTML in the <main> tag which is more appropriate for the primary content of the page. Add <header> in the <article> to group the top-level information. You can use <h1> instead of <h2> as the page contains only one heading. Use <footer> for the author information outside the main component. Wrap the attribution text in <p> tag.

    And your solution looks great. :)

    Marked as helpful

    1
  • TheAashay• 210

    @TheAashay

    Posted

    Your solution looks good. You can use rem instead of px for better responsiveness.

    Marked as helpful

    0
  • TheAashay• 210

    @TheAashay

    Posted

    Overall it looks good. You can give padding and border-radius to <p> element inside <div> with class label to make your solution look more similar to design.

    0
  • 7A9Oo• 80

    @7A9Oo

    Submitted

    What are you most proud of, and what would you do differently next time?

    i am desling with responsive layout i design first for mobile after that i use media queries for desktop

    What challenges did you encounter, and how did you overcome them?

    i have some challenges when i design for desktop with image header

    What specific areas of your project would you like help with?

    pls can someone review my code

    TheAashay• 210

    @TheAashay

    Posted

    You can put embed code in HTML file rather than CSS file to make fonts load faster and you can use rem instead of px for better accessibility and responsive design. Also you can revise the @media query to increase the min-width for desktop to more than 750px.

    Marked as helpful

    1
  • TheAashay• 210

    @TheAashay

    Posted

    The site looks good on desktop. Try to improve the media query for mobile.

    0
  • TheAashay• 210

    @TheAashay

    Posted

    Your site looks good. One thing you can do is to remove the hover from the "HTML & CSS Foundation" as it makes it's less visible. Instead, you can add hover to "These languages are the backbone of every website, defining structure, content, and presentation." paragraph to make it either bigger, darker in color or bolder, which will make it properly visible to people with specs.

    0
  • Mauricio• 120

    @Lucknagh

    Submitted

    What specific areas of your project would you like help with?

    Seeking guidance on areas where I can improve. Thanks

    TheAashay• 210

    @TheAashay

    Posted

    Hello Mauricio, I saw you code on GitHub, there <div> conteudo is the only element nested inside <div> container, here you can remove one of the <div> and apply CSS of it to another, it'll declutter the code a little. And you can add @media at-rule to change dimensions to fit properly in mobile. That's all from me, your solution looks similar to design provided so that's excellent.

    Marked as helpful

    0
  • P
    gmdpickett• 30

    @gmdpickett

    Submitted

    What are you most proud of, and what would you do differently next time?

    Finding a way to display the attribution text vertically next to the container.

    What challenges did you encounter, and how did you overcome them?

    Git / Github is the bane of my existence. I don't know why but it's always caused issues for me. Before moving into the next challenge I need to spend a little time learning more about these. I don't use them often enough to retain the knowledge of how they work and how to correct issues in them.

    TheAashay• 210

    @TheAashay

    Posted

    The output looks neat with that vertical attribution text. You can see git conventional commits to get better at Git.

    0