Recipe page

Community feedback

• 

  haquanq ®️•1,585

  @haquanqPosted 4 months ago

  Hi @7A9Oo,

  It's review time!!

  • When using section, article, you need to choose one not both (what type of content inside it?). Also, every section, article need to be provided a heading as it's child. You are using to many wrapping mixed with div, article, section (use it when you need it).
  • Avoid unnecessary div wrapping (div has no semantic meaning, choose it for styling only). For example, no need to wrap img with div, leave the img alone.
  • It is pretty clear that every bold text is a title/heading and you need to wrap it with section or article (this is the right time to use them).
  • Always keep your HTML simple and clean (don't div wrapping randomly) and use semantic HTML.
  • Never use fixed width, height on element (unless it really need it), this make your element less responsive, work around min/max-height, min/max-width instead.

  Check out my solution for more references

  Have a nice day!!!!

  Marked as helpful

  2

  ---

  

  TheAashay•210

  @TheAashayPosted 4 months ago

  This isn't my solution but your comment surely helped me. Thanks @haquanq

  1

  

  haquanq ®️•1,585

  @haquanqPosted 4 months ago

  @TheAashay that is glad to hear!

  1

  

  7A9Oo•80

  @7A9OoPosted 4 months ago

  @haquanq thanks for your review i apreciate it

  0
• 

  TheAashay•210

  @TheAashayPosted 4 months ago

  You can put embed code in HTML file rather than CSS file to make fonts load faster and you can use rem instead of px for better accessibility and responsive design. Also you can revise the @media query to increase the min-width for desktop to more than 750px.

  Marked as helpful

  1